[Merged by Bors] - feat: `LinearEquiv.congrQuadraticMap` and `LinearEquiv.congrRight₂` by mans0954 · Pull Request #17454 · leanprover-community/mathlib4

mans0954 · 2024-10-05T20:07:55Z

LinearEquiv.congrQuadraticMap matches LinearMap.compQuadraticMap, while LinearEquiv.congrRight₂ somewhat matches LinearMap.compr₂.

Used in #14988

github-actions · 2024-10-05T20:08:40Z

PR summary 3baf09a3ae

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

Declarations diff

+ _root_.LinearEquiv.congrQuadraticMap
+ _root_.LinearEquiv.congrQuadraticMap_refl
+ _root_.LinearEquiv.congrQuadraticMap_symm
+ _root_.LinearEquiv.congrRight_symm
+ _root_.LinearEquiv.congrRight₂
+ _root_.LinearEquiv.congrRight₂_apply
+ _root_.LinearEquiv.congrRight₂_refl
+ _root_.LinearEquiv.congrRight₂_trans

You can run this locally as follows

## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Mathlib/LinearAlgebra/QuadraticForm/Basic.lean

Mathlib/LinearAlgebra/BilinearForm/Hom.lean

eric-wieser · 2024-10-06T12:15:43Z

I'm not super happy with the naming, but I also don't have any better ideas.

Maybe another reviewer does!

maintainer merge

github-actions · 2024-10-06T12:16:00Z

🚀 Pull request has been placed on the maintainer queue by eric-wieser.

kbuzzard · 2024-10-07T09:20:57Z

If we're going to bikeshed over names then another possibility for LinearMap.BilinForm.congr₂ would I guess be LinearMap.BilinForm.congrRight. But I'd be happy to merge either choice.

eric-wieser · 2024-10-07T10:06:50Z

I think that would be rather confusing, because LinearMap.BilinForm.compRight sounds like it ought to be analogous, but is about the (right) domain rather than the codomain.

jcommelin · 2024-10-07T14:28:37Z

@mans0954 Unrelated, but github gives the following warning:

The head ref may contain hidden characters: "mans0954/congr\u2082"

I think it's good to stick to ascii for branch names.

jcommelin · 2024-10-07T14:30:51Z

@eric-wieser For equivs, congrRight is in fact about the codomain: e.g. LinearEquiv.congrRight

mans0954 · 2024-10-11T07:32:05Z

So, is the consensus for LinearMap.BilinForm.congrRight? I've pushed a commit with that.

eric-wieser · 2024-10-11T17:15:10Z

@eric-wieser For equivs, congrRight is in fact about the codomain: e.g. LinearEquiv.congrRight

I would argue this is not about Equivs, but about linear maps; that is, you get the definition in this PR by swapping LinearMap with BilinMap, not by swapping LinearEquiv with BilinMap.

So I guess you could go with LinearEquiv.congrRight₂ which is a little bit like the non-equivalence version LinearMap.compr₂.

mans0954 · 2024-10-14T18:05:10Z

you get the definition in this PR by swapping LinearMap with BilinMap, not by swapping LinearEquiv with BilinMap.

I'm afraid this has been going on for so long I have no recollection of where I adapted it from now.

mans0954 · 2024-10-14T18:42:35Z

@eric-wieser is this what you mean?

ecc7619

eric-wieser · 2024-10-14T20:09:26Z

Yes, that's what I meant. @jcommelin, are you happy with those?

bors d=@jcommelin

mathlib-bors · 2024-10-14T20:09:28Z

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

mans0954 · 2024-10-20T17:16:38Z

@jcommelin are you able to merge this PR now please?

jcommelin · 2024-10-24T04:39:50Z

bors merge

…17454) `LinearEquiv.congrQuadraticMap` matches `LinearMap.compQuadraticMap`, while `LinearEquiv.congrRight₂` somewhat matches `LinearMap.compr₂`. Used in #14988 Co-authored-by: Christopher Hoskin <[email protected]> Co-authored-by: Eric Wieser <[email protected]>

mathlib-bors · 2024-10-24T05:07:52Z

Pull request successfully merged into master.

Build succeeded:

mans0954 added 2 commits October 5, 2024 20:59

QuadraticMap.congr₂

e032808

LinearMap.BilinMap.congr₂

d2ec918

mans0954 mentioned this pull request Oct 5, 2024

[Merged by Bors] - refactor(LinearAlgebra/BilinearForm/TensorProduct): Tensor products of bilinear maps #14988

Closed

1 task

github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Oct 5, 2024

mans0954 and others added 3 commits October 5, 2024 21:31

congr₂_refl and congr₂_symm

3b08310

Rename

d22d812

Update Mathlib/LinearAlgebra/QuadraticForm/Basic.lean

02c2c5a

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

eric-wieser reviewed Oct 5, 2024

View reviewed changes

Mathlib/LinearAlgebra/QuadraticForm/Basic.lean Outdated Show resolved Hide resolved

eric-wieser reviewed Oct 5, 2024

View reviewed changes

Mathlib/LinearAlgebra/BilinearForm/Hom.lean Outdated Show resolved Hide resolved

mans0954 and others added 3 commits October 6, 2024 05:24

Add congr₂ section

1e125a3

tidy

6cd85c3

fix double-namespace

6e990d8

eric-wieser changed the title ~~feature(LinearAlgebra/QuadraticForm/Basic): congr₂~~ feature(LinearAlgebra/QuadraticForm/Basic): LinearEquiv.congrQuadraticMap and LinearMap.BilinMap.congr₂ Oct 6, 2024

eric-wieser changed the title ~~feature(LinearAlgebra/QuadraticForm/Basic): LinearEquiv.congrQuadraticMap and LinearMap.BilinMap.congr₂~~ feat: LinearEquiv.congrQuadraticMap and LinearMap.BilinMap.congr₂ Oct 6, 2024

github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 6, 2024

mans0954 added 2 commits October 11, 2024 08:30

rename LinearMap.BilinForm.congr₂ to LinearMap.BilinForm.congrRight

a4a6df9

Merge branch 'master' into mans0954/congr₂

8e4c30f

LinearEquiv.congrRight₂

ecc7619

eric-wieser changed the title ~~feat: LinearEquiv.congrQuadraticMap and LinearMap.BilinMap.congr₂~~ feat: LinearEquiv.congrQuadraticMap and LinearEquiv.congrRight₂ Oct 14, 2024

github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Oct 14, 2024

Merge branch 'master' into mans0954/congr₂

3baf09a

github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 24, 2024

mathlib-bors bot changed the title ~~feat: LinearEquiv.congrQuadraticMap and LinearEquiv.congrRight₂~~ [Merged by Bors] - feat: LinearEquiv.congrQuadraticMap and LinearEquiv.congrRight₂ Oct 24, 2024

mathlib-bors bot closed this Oct 24, 2024

mathlib-bors bot deleted the mans0954/congr₂ branch October 24, 2024 05:07

Conversation

mans0954 commented Oct 5, 2024 • edited by eric-wieser Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR summary 3baf09a3ae

Import changes for modified files

Declarations diff

Uh oh!

Uh oh!

Uh oh!

eric-wieser commented Oct 6, 2024

Uh oh!

github-actions bot commented Oct 6, 2024

Uh oh!

kbuzzard commented Oct 7, 2024

Uh oh!

eric-wieser commented Oct 7, 2024

Uh oh!

jcommelin commented Oct 7, 2024

Uh oh!

jcommelin commented Oct 7, 2024

Uh oh!

mans0954 commented Oct 11, 2024

Uh oh!

eric-wieser commented Oct 11, 2024

Uh oh!

mans0954 commented Oct 14, 2024

Uh oh!

mans0954 commented Oct 14, 2024

Uh oh!

eric-wieser commented Oct 14, 2024

Uh oh!

mathlib-bors bot commented Oct 14, 2024

Uh oh!

mans0954 commented Oct 20, 2024

Uh oh!

jcommelin commented Oct 24, 2024

Uh oh!

mathlib-bors bot commented Oct 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mans0954 commented Oct 5, 2024 •

edited by eric-wieser

Loading

github-actions bot commented Oct 5, 2024 •

edited

Loading