Skip to content

[Merged by Bors] - feat(Algebra/Group/Pointwise/Set/Basic): sInter and sUnion forms of pointwise operations#17253

Closed
mans0954 wants to merge 30 commits intomasterfrom
mans0954/smul-lemmas
Closed

[Merged by Bors] - feat(Algebra/Group/Pointwise/Set/Basic): sInter and sUnion forms of pointwise operations#17253
mans0954 wants to merge 30 commits intomasterfrom
mans0954/smul-lemmas

Conversation

@mans0954
Copy link
Copy Markdown
Collaborator

@mans0954 mans0954 commented Sep 29, 2024

Provides sInter and sUnion versions of pointwise algebraic operations on sets.

Needed in #17029


Open in Gitpod

@mans0954 mans0954 added the t-algebra Algebra (groups, rings, fields, etc) label Sep 29, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 29, 2024

PR summary 2e23193276

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ div_sInter_subset
+ div_sUnion
+ image2_sInter_left_subset
+ image2_sInter_right_subset
+ image2_sInter_subset_left
+ image2_sInter_subset_right
+ image2_sUnion_left
+ image2_sUnion_right
+ mul_sInter_subset
+ mul_sUnion
+ sInter_div_subset
+ sInter_inv
+ sInter_mul_subset
+ sInter_smul_subset
+ sInter_vsub_subset
+ sUnion_div
+ sUnion_inv
+ sUnion_mul
+ sUnion_smul
+ sUnion_vsub
+ smul_sInter_subset
+ smul_sUnion
+ smul_set_sInter_subset
+ smul_set_sUnion
+ vsub_sInter_subset
+ vsub_sUnion

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@mans0954 mans0954 added WIP Work in progress awaiting-author A reviewer has asked the author a question or requested changes. labels Sep 29, 2024
@mans0954 mans0954 changed the title feature(Algebra/Group/Pointwise/Set/Basic): Some smul lemmas feature(Algebra/Group/Pointwise/Set/Basic): sInter forms of pointwise operations Sep 29, 2024
@mans0954 mans0954 changed the title feature(Algebra/Group/Pointwise/Set/Basic): sInter forms of pointwise operations feature(Algebra/Group/Pointwise/Set/Basic): sInter and sUnion forms of pointwise operations Sep 29, 2024
@mans0954 mans0954 removed WIP Work in progress awaiting-author A reviewer has asked the author a question or requested changes. labels Sep 29, 2024
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 30, 2024
@mans0954 mans0954 removed the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 30, 2024
@YaelDillies YaelDillies changed the title feature(Algebra/Group/Pointwise/Set/Basic): sInter and sUnion forms of pointwise operations feat(Algebra/Group/Pointwise/Set/Basic): sInter and sUnion forms of pointwise operations Sep 30, 2024
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 30, 2024
@mans0954 mans0954 removed the awaiting-author A reviewer has asked the author a question or requested changes. label Sep 30, 2024
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 30, 2024
@b-mehta
Copy link
Copy Markdown
Contributor

b-mehta commented Sep 30, 2024

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Sep 30, 2024
mathlib-bors bot pushed a commit that referenced this pull request Sep 30, 2024
…ointwise operations (#17253)

Provides `sInter` and `sUnion` versions of  pointwise algebraic operations on sets.

Needed in #17029



Co-authored-by: Christopher Hoskin <[email protected]>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Group/Pointwise/Set/Basic): sInter and sUnion forms of pointwise operations [Merged by Bors] - feat(Algebra/Group/Pointwise/Set/Basic): sInter and sUnion forms of pointwise operations Sep 30, 2024
@mathlib-bors mathlib-bors bot closed this Sep 30, 2024
@mathlib-bors mathlib-bors bot deleted the mans0954/smul-lemmas branch September 30, 2024 21:32
fbarroero pushed a commit that referenced this pull request Oct 2, 2024
…ointwise operations (#17253)

Provides `sInter` and `sUnion` versions of  pointwise algebraic operations on sets.

Needed in #17029



Co-authored-by: Christopher Hoskin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants