Skip to content

[Merged by Bors] - feat(Data/List/Chain): lemmas on Chain' and replicate#17106

Closed
vihdzp wants to merge 6 commits intomasterfrom
vi.chain_replicate
Closed

[Merged by Bors] - feat(Data/List/Chain): lemmas on Chain' and replicate#17106
vihdzp wants to merge 6 commits intomasterfrom
vi.chain_replicate

Conversation

@vihdzp
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp commented Sep 24, 2024

Co-authored-by: Bhavik Mehta [email protected]


Open in Gitpod

@vihdzp vihdzp added the t-data Data (lists, quotients, numbers, etc) label Sep 24, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 24, 2024

PR summary 7784cd0f31

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ chain'_eq_iff_eq_replicate
+ chain'_replicate_of_rel
+ chain_eq_iff_eq_replicate
+ chain_replicate_of_rel

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Comment thread Mathlib/Data/List/Chain.lean
Comment thread Mathlib/Data/List/Chain.lean Outdated
Comment thread Mathlib/Data/List/Chain.lean Outdated
@b-mehta
Copy link
Copy Markdown
Contributor

b-mehta commented Oct 2, 2024 via email

@vihdzp
Copy link
Copy Markdown
Collaborator Author

vihdzp commented Oct 3, 2024

You are right, there's other possible theorems of this sort. Another one would be simply r a aChain' (replicate n a).

I'll rename once I'm able to.

@b-mehta
Copy link
Copy Markdown
Contributor

b-mehta commented Oct 3, 2024

Actually your suggested lemma is probably a better thing to add anyway, instead of our current statement; it's just stronger!

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 5, 2024
@vihdzp vihdzp removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 7, 2024
Copy link
Copy Markdown
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 7, 2024

🚀 Pull request has been placed on the maintainer queue by b-mehta.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 7, 2024
@fpvandoorn
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 7, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 7, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 7, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/List/Chain): lemmas on Chain' and replicate [Merged by Bors] - feat(Data/List/Chain): lemmas on Chain' and replicate Oct 7, 2024
@mathlib-bors mathlib-bors bot closed this Oct 7, 2024
@mathlib-bors mathlib-bors bot deleted the vi.chain_replicate branch October 7, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants