feat(Data/List/SplitBy): characterization of List.splitBy#16837
Closed
feat(Data/List/SplitBy): characterization of List.splitBy#16837
List.splitBy#16837Conversation
PR summary b4ec708ec6
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Data.List.SplitBy | 279 | 281 | +2 (+0.72%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Data.List.SplitBy |
2 |
Declarations diff
+ getLast_eq_of_mem_getLast?
+ getLast_flatten_of_getLast_ne_nil
+ getLast_getLast_splitBy
+ head_eq_of_mem_head?
+ head_flatten_of_head_ne_nil
+ head_head_splitBy
+ splitBy_append
+ splitBy_append_cons
+ splitBy_eq_iff
+ splitBy_eq_nil_iff
+ splitBy_flatten
+ splitBy_ne_nil_iff
+ splitBy_of_chain'
+ splitBy_singleton
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
mathlib4-dependent-issues-bot
added
the
blocked-by-other-PR
This was referenced Sep 24, 2024
mathlib4-dependent-issues-bot
removed
the
blocked-by-other-PR
Collaborator
|
This PR/issue depends on: |
leanprover-community-bot-assistant
added
the
merge-conflict
leanprover-community-bot-assistant
removed
the
merge-conflict
leanprover-community-bot-assistant
added
the
merge-conflict
vihdzp
changed the title
List.groupByList.splitBy
leanprover-community-bot-assistant
removed
the
merge-conflict
vihdzp
changed the title
List.splitByList.splitBy
leanprover-community-bot-assistant
added
the
merge-conflict
leanprover-community-bot-assistant
removed
the
merge-conflict
YaelDillies
reviewed
Nov 17, 2024
YaelDillies
added
the
awaiting-author
Collaborator
Author
|
I managed to prove the result on A lot of the proofs in this PR are very complicated. If someone can figure a way to simplify them it'd be greatly appreciated. |
vihdzp
removed
the
awaiting-author
YaelDillies
reviewed
Feb 17, 2025
Contributor
YaelDillies
left a comment
YaelDillies
left a comment
There was a problem hiding this comment.
I've golfed your proofs a bit. simp_all is a good tactic for you to learn.
|
|
||
| variable {α : Type*} {m : List α} | ||
|
|
||
| theorem head_eq_of_mem_head? {x} (hx : x ∈ m.head?) : |
Contributor
There was a problem hiding this comment.
Suggested change
| theorem head_eq_of_mem_head? {x} (hx : x ∈ m.head?) : | |
| theorem head_of_mem_head? {x} (hx : x ∈ m.head?) : |
| · contradiction | ||
| · simpa using hx | ||
|
|
||
| theorem getLast_eq_of_mem_getLast? {x} (hx : x ∈ m.getLast?) : |
Contributor
There was a problem hiding this comment.
Suggested change
| theorem getLast_eq_of_mem_getLast? {x} (hx : x ∈ m.getLast?) : | |
| theorem getLast_of_mem_getLast? {x} (hx : x ∈ m.getLast?) : |
| | cons _ _ => flatten_splitByLoop | ||
|
|
||
| @[simp] | ||
| theorem splitBy_eq_nil_iff {r : α → α → Bool} {l : List α} : l.splitBy r = [] ↔ l = [] := by |
Contributor
There was a problem hiding this comment.
Suggested change
| theorem splitBy_eq_nil_iff {r : α → α → Bool} {l : List α} : l.splitBy r = [] ↔ l = [] := by | |
| theorem splitBy_eq_nil {r : α → α → Bool} {l : List α} : l.splitBy r = [] ↔ l = [] := by |
| · rintro rfl | ||
| rfl | ||
|
|
||
| theorem splitBy_ne_nil_iff {r : α → α → Bool} {l : List α} : l.splitBy r ≠ [] ↔ l ≠ [] := |
Contributor
There was a problem hiding this comment.
Suggested change
| theorem splitBy_ne_nil_iff {r : α → α → Bool} {l : List α} : l.splitBy r ≠ [] ↔ l ≠ [] := | |
| theorem splitBy_ne_nil {r : α → α → Bool} {l : List α} : l.splitBy r ≠ [] ↔ l ≠ [] := |
YaelDillies
added
the
awaiting-author
leanprover-community-bot-assistant
added
the
merge-conflict
This was referenced Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List.GroupBy#16818