[Merged by Bors] - refactor(Topology/Order/ScottTopology): Unify concepts of Scott Topology#16523
Closed
[Merged by Bors] - refactor(Topology/Order/ScottTopology): Unify concepts of Scott Topology#16523
Conversation
PR summary 31d22d1cf3Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Topology.OmegaCompletePartialOrder | 570 | 678 | +108 (+18.95%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Topology.OmegaCompletePartialOrder |
108 |
Declarations diff
+ DirSupInacc.dirSupInaccOn
+ DirSupInaccOn
+ DirSupInaccOn.mono
+ Topology.IsScott.ωscottContinuous_iff_continuous
+ dirSupInaccOn_of_isOpen
+ dirSupInaccOn_univ
+ instance : @IsScottHausdorff α D _ (scottHausdorff α D)
+ instance : IsScott (WithScott α) univ := ⟨rfl⟩
+ instance : TopologicalSpace (WithScott α) := scott α univ
+ instance [TopologicalSpace α] [IsUpper α] : IsScott α univ
+ isOpen_iff_isUpperSet_and_dirSupInaccOn
+ isOpen_iff_ωScottContinuous_mem
+ scott_eq_Scott
- dirSupInacc_of_isOpen
- instance : @IsScottHausdorff α _ (scottHausdorff α)
- instance : IsScott (WithScott α) := ⟨rfl⟩
- instance : TopologicalSpace (WithScott α) := scott α
- instance [TopologicalSpace α] [IsUpper α] : IsScott α
- isOpen_iff_isUpperSet_and_dirSupInacc
--++ dirSupClosed_of_isClosed
--++ topology_eq
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
leanprover-community-bot-assistant
added
the
merge-conflict
github-actions
bot
added
large-import
leanprover-community-bot-assistant
removed
the
merge-conflict
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mans0954
removed
the
awaiting-author
YaelDillies
reviewed
Oct 13, 2024
YaelDillies
added
the
awaiting-author
Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Yaël Dillies <[email protected]>
mans0954
removed
the
awaiting-author
YaelDillies
reviewed
Oct 13, 2024
Contributor
YaelDillies
left a comment
YaelDillies
left a comment
There was a problem hiding this comment.
maintainer merge
apart from that
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
github-actions
bot
added
the
maintainer-merge
Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Yaël Dillies <[email protected]>
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 13, 2024
…ogy (#16523) Unify Scott Topologies, following on from #13201 and #16826. Originally Mathlib had a notion of ω-Scott Continuity and ω-Scott Topology based on Chains for ω-complete partial orders. Previously we introduced a notion of Scott Continuity and Scott Topology based on directed sets for arbitrary pre-orders (#2508). In #13201, we generalised our definition of Scott Continuity to include ω-Scott Continuity as a special case. This PR continues that work by generalising our notion of Scott Topology to include ω-Scott Topology as a special case. `Topology.IsScott.scottContinuous_iff_continuous` and `Topology.IsScott.ωscottContinuous_iff_continuous` have almost identical proofs and are presumably special cases of a more general result that I have not yet formulated. However I think this PR covers enough ground to be worth considering at this stage. Co-authored-by: Christopher Hoskin <[email protected]> Co-authored-by: Christopher Hoskin <[email protected]>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify Scott Topologies, following on from #13201 and #16826.
Originally Mathlib had a notion of ω-Scott Continuity and ω-Scott Topology based on Chains for ω-complete partial orders. Previously we introduced a notion of Scott Continuity and Scott Topology based on directed sets for arbitrary pre-orders (#2508). In #13201, we generalised our definition of Scott Continuity to include ω-Scott Continuity as a special case. This PR continues that work by generalising our notion of Scott Topology to include ω-Scott Topology as a special case.
Topology.IsScott.scottContinuous_iff_continuousandTopology.IsScott.ωscottContinuous_iff_continuoushave almost identical proofs and are presumably special cases of a more general result that I have not yet formulated. However I think this PR covers enough ground to be worth considering at this stage.