Closed
Conversation
astrainfinita
added
awaiting-review
awaiting-CI
astrainfinita
changed the title
Nat.binaryRec Nat.div2 Nat.bodd
PR summary 60c51c067a
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Data.Nat.Bits | 123 | 103 | -20 (-16.26%) |
| Mathlib.Data.Nat.Size | 155 | 150 | -5 (-3.23%) |
| Mathlib.Logic.Equiv.Nat | 293 | 292 | -1 (-0.34%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Data.Nat.Bits |
-20 |
Mathlib.Data.Nat.Size |
-5 |
Mathlib.Data.FP.Basic Mathlib.Logic.Equiv.Nat |
-1 |
Declarations diff
+ div2_lt_self
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
1 task
github-actions
bot
removed
the
awaiting-CI
Member
|
Please describe how and why did you change the definition(s) in the commit message. |
ghost
added
the
merge-conflict
ghost
removed
the
merge-conflict
ghost
added
the
merge-conflict
ghost
removed
the
merge-conflict
ghost
added
the
merge-conflict
leanprover-community-bot-assistant
added
the
merge-conflict
leanprover-community-bot-assistant
removed
the
merge-conflict
leanprover-community-bot-assistant
added
the
merge-conflict
leanprover-community-bot-assistant
removed
the
merge-conflict
astrainfinita
changed the title
Nat.bit Nat.div2 Nat.boddNat.div2 Nat.bodd
mathlib4-dependent-issues-bot
added
the
blocked-by-other-PR
leanprover-community-bot-assistant
added
the
merge-conflict
mathlib4-dependent-issues-bot
removed
the
blocked-by-other-PR
Collaborator
|
This PR/issue depends on: |
github-actions
bot
removed
the
merge-conflict
eric-wieser
reviewed
Apr 9, 2025
Collaborator
|
This pull request has conflicts, please merge |
leanprover-community-bot-assistant
added
the
merge-conflict
Collaborator
Author
|
This PR has been migrated to a fork-based workflow: #36970 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new definitions are faster than the old ones.
Nat.binaryRecwill be moved to batteries (leanprover-community/batteries#799) or core (leanprover/lean4#3756), so relevant contents are moved to a new file temporarily.Natinto a new file #15567Nat.bit#19666