[Merged by Bors] - refactor(Algebra/Star/Order): Use NonUnitalStarRingHom in Algebra.Star.Order#13089
Closed
[Merged by Bors] - refactor(Algebra/Star/Order): Use NonUnitalStarRingHom in Algebra.Star.Order#13089
Conversation
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
ghost
added
the
blocked-by-other-PR
Import summaryNo significant changes to the import graph |
PR summary 809384e3dd
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Star.Order | 507 | 508 | +1 (+0.20%) |
Import changes for all files
| Files | Import difference |
|---|---|
24 filesMathlib.Analysis.SpecialFunctions.Trigonometric.Chebyshev Mathlib.Analysis.Calculus.FDeriv.Analytic Mathlib.Data.Complex.Exponential Mathlib.Algebra.Order.Ring.Star Mathlib.LinearAlgebra.Matrix.DotProduct Mathlib.Data.Matrix.Rank Mathlib.Data.Rat.Star Mathlib.Algebra.Star.CHSH Mathlib.Algebra.Star.Order Mathlib.Data.Int.Star Mathlib.Analysis.Analytic.Meromorphic Mathlib.Analysis.Calculus.LocalExtr.Polynomial Mathlib.Data.Real.StarOrdered Mathlib.Analysis.Analytic.Linear Mathlib.Analysis.Analytic.Constructions Mathlib.Analysis.Analytic.Composition Mathlib.Analysis.Analytic.Basic Mathlib.Analysis.Analytic.Uniqueness Mathlib.Analysis.Analytic.CPolynomial Mathlib.Geometry.Manifold.AnalyticManifold Mathlib.LinearAlgebra.Matrix.GeneralLinearGroup.Card Mathlib.Analysis.Analytic.IsolatedZeros Mathlib.Analysis.Analytic.Inverse Mathlib.Analysis.Analytic.Polynomial |
1 |
Declarations diff
+ NonUnitalStarRingHom.map_le_map_of_map_star
+ instance (priority := 100) StarRingEquivClass.instOrderIsoClass [EquivLike F R S]
+ instance (priority := 100) StarRingHomClass.instOrderHomClass [FunLike F R S]
- NonUnitalRingHom.map_le_map_of_map_star
- instance (priority := 100) StarRingHomClass.instOrderHomClass [FunLike F R S] [StarHomClass F R S]
- instance (priority := 100) StarRingHomClass.instOrderIsoClass [EquivLike F R S] [StarHomClass F R S]
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
ghost
added
the
merge-conflict
ghost
removed
merge-conflict
|
This PR/issue depends on: |
ghost
added
the
merge-conflict
ghost
removed
the
merge-conflict
Collaborator
Author
|
@riccardobrasca I assume you added the |
Member
Yes, feel free to remove it if it's ready for reviews. |
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
…r.Order (#13089) Refactor `Algebra.Star.Order` to use the new non-unital *-ring homomorphisms / isomorphisms introduced in #12924 Co-authored-by: Christopher Hoskin <[email protected]> Co-authored-by: Christopher Hoskin <[email protected]>
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
…r.Order (#13089) Refactor `Algebra.Star.Order` to use the new non-unital *-ring homomorphisms / isomorphisms introduced in #12924 Co-authored-by: Christopher Hoskin <[email protected]> Co-authored-by: Christopher Hoskin <[email protected]>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
mathlib-bors
bot
deleted the
mans0954/StarRingEquivClass.instOrderIsoClass
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
Algebra.Star.Orderto use the new non-unital *-ring homomorphisms / isomorphisms introduced in #12924