[Merged by Bors] - feat(Algebra/Star/StarRingHom): Add non-unital star ring homomorphisms#12924
Closed
[Merged by Bors] - feat(Algebra/Star/StarRingHom): Add non-unital star ring homomorphisms#12924
Conversation
Closed
3 tasks
Contributor
|
no need to include me in the copyright. |
j-loreaux
reviewed
May 20, 2024
Contributor
j-loreaux
left a comment
j-loreaux
left a comment
There was a problem hiding this comment.
Looks like a decent start, but still a lot of the API is missing. It's okay if you add it in follow-up PRs though.
Also, when you're done with this, would you mind fixing up StarRingHomClass.instOrderHomClass and StarRingHomClass.instOrderIsoClass to use these new classes (and renaming the latter?
j-loreaux
added
awaiting-author
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
j-loreaux
reviewed
Jun 24, 2024
Contributor
j-loreaux
left a comment
j-loreaux
left a comment
There was a problem hiding this comment.
Looks pretty good. I'm ready to merge subject to these comments and Eric's response to my question above.
j-loreaux
added
awaiting-author
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: Jireh Loreaux <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mans0954
added
awaiting-review
and removed
awaiting-author
Contributor
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
#12924) Definitions and basic properties of non-unital star ring homomorphisms Co-authored-by: Christopher Hoskin <[email protected]> Co-authored-by: Christopher Hoskin <[email protected]>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
#12924) Definitions and basic properties of non-unital star ring homomorphisms Co-authored-by: Christopher Hoskin <[email protected]> Co-authored-by: Christopher Hoskin <[email protected]>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
…r.Order (#13089) Refactor `Algebra.Star.Order` to use the new non-unital *-ring homomorphisms / isomorphisms introduced in #12924 Co-authored-by: Christopher Hoskin <[email protected]> Co-authored-by: Christopher Hoskin <[email protected]>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
…r.Order (#13089) Refactor `Algebra.Star.Order` to use the new non-unital *-ring homomorphisms / isomorphisms introduced in #12924 Co-authored-by: Christopher Hoskin <[email protected]> Co-authored-by: Christopher Hoskin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definitions and basic properties of non-unital star ring homomorphisms