[Merged by Bors] - chore(LinearAlgebra/BilinearForm): Add missing deprecated dates#12547
Closed
[Merged by Bors] - chore(LinearAlgebra/BilinearForm): Add missing deprecated dates#12547
Conversation
Collaborator
Author
|
@grunweg it turns out |
Contributor
|
I know; I'm eagerly awaiting the upgrade :-) Sure, waiting is fine with me! |
Contributor
|
Except for the date issue, this PR looks good to me. |
grunweg
added
blocked-by-core-release
Contributor
|
With the Lean upgrade just landed, this PR should be ready to be updated! |
grunweg
added
awaiting-author
mans0954
added
awaiting-review
and removed
awaiting-author
Collaborator
Author
|
@grunweg how's that? |
grunweg
approved these changes
May 3, 2024
Contributor
grunweg
left a comment
grunweg
left a comment
There was a problem hiding this comment.
Looks good to me; thanks for following up on your PRs!
Ruben-VandeVelde
approved these changes
May 5, 2024
Contributor
Ruben-VandeVelde
left a comment
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
maintainer merge
Thanks!
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
github-actions
bot
added
the
maintainer-merge
Contributor
|
bors r+ |
github-actions
bot
added
ready-to-merge
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds dates to results deprecated in #12132 and #12078.