[Merged by Bors] - chore: reformat deprecation warnings on one line, if possible#12335
Closed
[Merged by Bors] - chore: reformat deprecation warnings on one line, if possible#12335
Conversation
grunweg
force-pushed
the
MR-deprecation-warnings-one-line
branch
from
5293a87 to
d09723c
Compare
ghost
added
the
merge-conflict
ghost
removed
the
merge-conflict
grunweg
added
the
tech debt
Member
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
Occasionally, remove a "deprecated by" or "deprecated since", to fit the line length. This is desirable (to me) because - it's more compact: I don't see a good reason for these declarations taking up more space than needed; as I understand it, deprecated lemmas are not supposed to be used in mathlib anyway - putting the date on the same line as the attribute makes it easier to discover un-dated deprecations; they also ease writing a tool to replace these by a machine-readable version using leanprover/lean4#3968
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
Occasionally, remove a "deprecated by" or "deprecated since", to fit the line length. This is desirable (to me) because - it's more compact: I don't see a good reason for these declarations taking up more space than needed; as I understand it, deprecated lemmas are not supposed to be used in mathlib anyway - putting the date on the same line as the attribute makes it easier to discover un-dated deprecations; they also ease writing a tool to replace these by a machine-readable version using leanprover/lean4#3968
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
Occasionally, remove a "deprecated by" or "deprecated since", to fit the line length. This is desirable (to me) because - it's more compact: I don't see a good reason for these declarations taking up more space than needed; as I understand it, deprecated lemmas are not supposed to be used in mathlib anyway - putting the date on the same line as the attribute makes it easier to discover un-dated deprecations; they also ease writing a tool to replace these by a machine-readable version using leanprover/lean4#3968
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occasionally, remove a "deprecated by" or "deprecated since", to fit the line length.
This is desirable (to me) because
as I understand it, deprecated lemmas are not supposed to be used in mathlib anyway
they also ease writing a tool to replace these by a machine-readable version using feat: improve @[deprecated] attr leanprover/lean4#3968
Best reviewed ignoring whitespace and line breaks (there is essentially nothing happening otherwise!).
Sadly, github's UI doesn't allow the latter, so isn't as useful here.