[Merged by Bors] - refactor(LinearAlgebra/QuadraticForm): Replace BilinForm with a scalar valued bi LinearMap#10238
Closed
[Merged by Bors] - refactor(LinearAlgebra/QuadraticForm): Replace BilinForm with a scalar valued bi LinearMap#10238
BilinForm with a scalar valued bi LinearMap#10238Conversation
ghost
added
the
blocked-by-other-PR
Collaborator
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 1fe7c06. Benchmark Metric Change
=====================================================================================
+ ~Mathlib.LinearAlgebra.CliffordAlgebra.BaseChange instructions -14.2%
- ~Mathlib.LinearAlgebra.QuadraticForm.Basic instructions 30.0%
- ~Mathlib.LinearAlgebra.QuadraticForm.TensorProduct instructions 57.9%
+ ~Mathlib.LinearAlgebra.QuadraticForm.TensorProduct.Isometries instructions -12.5% |
ghost
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
ghost
removed
the
merge-conflict
ghost
added
the
merge-conflict
ghost
removed
the
merge-conflict
Member
|
bors d+ Thanks for this, it now looks excellent! |
Contributor
|
✌️ mans0954 can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
Collaborator
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
…lar valued bi `LinearMap` (#10238) Following on from #10097, which converted the companion of a quadratic form with a bilinear map, this PR replaces a number of results about quadratic forms and bilinear forms with results about quadratic forms and scalar valued bilinear maps. The long term aim is to be able to consider quadratic maps. The main change is to `LinearAlgebra/QuadraticForm/Basic`, but this necessitates changes throughout `LinearAlgebra/QuadraticForm/`. Minor changes are also required elsewhere: - `LinearAlgebra/CliffordAlgebra/` - `LinearAlgebra/Matrix/PosDef` - `LinearAlgebra/SesquilinearForm` - A number of additional results about tensor products and linear maps are also required. Co-authored-by: Eric Wieser <[email protected]> Co-authored-by: Christopher Hoskin <[email protected]>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
BilinForm with a scalar valued bi LinearMapBilinForm with a scalar valued bi LinearMap
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
…lar valued bi `LinearMap` (#10238) Following on from #10097, which converted the companion of a quadratic form with a bilinear map, this PR replaces a number of results about quadratic forms and bilinear forms with results about quadratic forms and scalar valued bilinear maps. The long term aim is to be able to consider quadratic maps. The main change is to `LinearAlgebra/QuadraticForm/Basic`, but this necessitates changes throughout `LinearAlgebra/QuadraticForm/`. Minor changes are also required elsewhere: - `LinearAlgebra/CliffordAlgebra/` - `LinearAlgebra/Matrix/PosDef` - `LinearAlgebra/SesquilinearForm` - A number of additional results about tensor products and linear maps are also required. Co-authored-by: Eric Wieser <[email protected]> Co-authored-by: Christopher Hoskin <[email protected]>
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
…lar valued bi `LinearMap` (#10238) Following on from #10097, which converted the companion of a quadratic form with a bilinear map, this PR replaces a number of results about quadratic forms and bilinear forms with results about quadratic forms and scalar valued bilinear maps. The long term aim is to be able to consider quadratic maps. The main change is to `LinearAlgebra/QuadraticForm/Basic`, but this necessitates changes throughout `LinearAlgebra/QuadraticForm/`. Minor changes are also required elsewhere: - `LinearAlgebra/CliffordAlgebra/` - `LinearAlgebra/Matrix/PosDef` - `LinearAlgebra/SesquilinearForm` - A number of additional results about tensor products and linear maps are also required. Co-authored-by: Eric Wieser <[email protected]> Co-authored-by: Christopher Hoskin <[email protected]>
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
…lar valued bi `LinearMap` (#10238) Following on from #10097, which converted the companion of a quadratic form with a bilinear map, this PR replaces a number of results about quadratic forms and bilinear forms with results about quadratic forms and scalar valued bilinear maps. The long term aim is to be able to consider quadratic maps. The main change is to `LinearAlgebra/QuadraticForm/Basic`, but this necessitates changes throughout `LinearAlgebra/QuadraticForm/`. Minor changes are also required elsewhere: - `LinearAlgebra/CliffordAlgebra/` - `LinearAlgebra/Matrix/PosDef` - `LinearAlgebra/SesquilinearForm` - A number of additional results about tensor products and linear maps are also required. Co-authored-by: Eric Wieser <[email protected]> Co-authored-by: Christopher Hoskin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #10097, which converted the companion of a quadratic form with a bilinear map, this PR replaces a number of results about quadratic forms and bilinear forms with results about quadratic forms and scalar valued bilinear maps. The long term aim is to be able to consider quadratic maps.
The main change is to
LinearAlgebra/QuadraticForm/Basic, but this necessitates changes throughoutLinearAlgebra/QuadraticForm/. Minor changes are also required elsewhere:LinearAlgebra/CliffordAlgebra/LinearAlgebra/Matrix/PosDefLinearAlgebra/SesquilinearForm