[Merged by Bors] - feat(CategoryTheory/Functor): definition of Kan extensions#10195
Closed
[Merged by Bors] - feat(CategoryTheory/Functor): definition of Kan extensions#10195
Conversation
joelriou
added
t-category-theory
11 tasks
github-actions
bot
removed
the
awaiting-CI
yuma-mizuno
approved these changes
Feb 3, 2024
Collaborator
yuma-mizuno
left a comment
yuma-mizuno
left a comment
There was a problem hiding this comment.
Apart from a few style corrections, it looks great to me!
| tensor_μ C (M.X, N.X) (M.X, N.X) ≫ (M.mul ⊗ N.mul) = | ||
| (ρ_ (M.X ⊗ N.X)).hom := by | ||
| simp only [whiskerLeft_comp_assoc] | ||
| simp only [MonoidalCategory.whiskerLeft_comp_assoc] |
Collaborator
There was a problem hiding this comment.
Although this comment is not directly related to this PR, what do you think about renaming CategoryTheory.whiskerLeft_comp to CategoryTheory.NatTrans.whiskerLeft_comp or CategoryTheory.Functor.whiskerLeft_comp in another PR to avoid this kind of fixes?
Contributor
Author
There was a problem hiding this comment.
If we do this name change, in principle, for consistency, we should also rename CategoryTheory.whiskerLeft to CategoryTheory.NatTrans.whiskerLeft, and similarly isoWhiskerLeft -> NatIso.whiskerLeft, etc? I am not sure we need to do the change, but I would be ok with it.
Co-authored-by: Yuma Mizuno <[email protected]>
Co-authored-by: Yuma Mizuno <[email protected]>
Co-authored-by: Yuma Mizuno <[email protected]>
Co-authored-by: Yuma Mizuno <[email protected]>
ghost
added
the
merge-conflict
ghost
removed
the
merge-conflict
ghost
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
This PR introduces basic definitions for Kan extensions of functors. It prepares for future development of derived functors and a refactor of the file `CategoryTheory.Limits.KanExtension`. Co-authored-by: Joël Riou <[email protected]>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
This PR introduces basic definitions for Kan extensions of functors. It prepares for future development of derived functors and a refactor of the file `CategoryTheory.Limits.KanExtension`. Co-authored-by: Joël Riou <[email protected]>
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
This PR introduces basic definitions for Kan extensions of functors. It prepares for future development of derived functors and a refactor of the file `CategoryTheory.Limits.KanExtension`. Co-authored-by: Joël Riou <[email protected]>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces basic definitions for Kan extensions of functors. It prepares for future development of derived functors and a refactor of the file
CategoryTheory.Limits.KanExtension.