Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(group_theory/subgroup): saturated subgroups#8137

Closed
jcommelin wants to merge 6 commits intomasterfrom
saturated-subgroup-def
Closed

[Merged by Bors] - feat(group_theory/subgroup): saturated subgroups#8137
jcommelin wants to merge 6 commits intomasterfrom
saturated-subgroup-def

Conversation

@jcommelin
Copy link
Copy Markdown
Member

From LTE


Open in Gitpod

@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Jun 30, 2021
@eric-wieser
Copy link
Copy Markdown
Member

I think @fpvandoorn is just around the corner from making to_additive work properly on smul / npow - perhaps it makes sense to wait for that PR first?

Copy link
Copy Markdown
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try to merge master and applying to_additive to this file?

LGTM otherwise.

@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 12, 2021
@jcommelin
Copy link
Copy Markdown
Member Author

Done. It works great! Thanks @fpvandoorn 🐙

@fpvandoorn
Copy link
Copy Markdown
Member

Good to hear!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 9, 2021
bors bot pushed a commit that referenced this pull request Aug 9, 2021
@bors
Copy link
Copy Markdown

bors bot commented Aug 9, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory/subgroup): saturated subgroups [Merged by Bors] - feat(group_theory/subgroup): saturated subgroups Aug 9, 2021
@bors bors bot closed this Aug 9, 2021
@bors bors bot deleted the saturated-subgroup-def branch August 9, 2021 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants