pgmoon.crypto better support for resty.openssl / resty.string libraries #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Contributor
Author
|
Hi @leafo, if you have time, could you give some eye to this? I can make changes as requested. |
Owner
|
Thanks, looks good |
Owner
|
Sorry about the delay publishing, 1.14 is now out on luarocks and opm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
random_bytesfunction topgmoon.cryptocompatibility layer and makes use of it inpgmoon.initx509_digestfunction topgmoon.cryptocompatibility layer and makes use of it inpgmoon.initresty.opensslsupport tohmac_sha256resty.opensslandresty.stringsupport todigest_sha256We don't anymore ship
luaosslwith Kong and this causes our users issues withscram-sha-256authentication as reported in: Kong/kong#8259This PR fixes it so that it works with
resty.openssllibrary too (the one that is shipped with Kong).