Fix a bunch of errors and deprecation for LLVM 21#4950
Merged
thewilsonator merged 9 commits intoldc-developers:masterfrom Jul 7, 2025
Merged
Fix a bunch of errors and deprecation for LLVM 21#4950thewilsonator merged 9 commits intoldc-developers:masterfrom
thewilsonator merged 9 commits intoldc-developers:masterfrom
Conversation
Contributor
Author
|
Also it seems that For now I have just copied what the old code did inline. |
kubo39
reviewed
Jun 8, 2025
Contributor
Author
|
This should be good to go now, but please give a thorough review on |
Contributor
Author
|
Ping |
Contributor
Author
|
I will merge this tomorrow if there are no objections. |
kinke
added a commit
to kinke/ldc
that referenced
this pull request
Jul 28, 2025
Fix the undefined `getGlobalContext()` symbol for libldc-jit.so, showing up with CircleCI, introduced in ldc-developers#4950.
kinke
added a commit
that referenced
this pull request
Jul 28, 2025
Fix the undefined `getGlobalContext()` symbol for libldc-jit.so, showing up with CircleCI, introduced in #4950.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Best reviewed per commit.
I am unsure what the correct value to use for the
llvm::LocationSizein the case we don't know the size.There are still a bunch of deprecations from using
InsertPositione.g. fromgIR->topallocapoint()instead ofBasicBlock::iteratorsfor insertion.