gen: fix control-flow protection attribute marking#4828
Merged
kinke merged 2 commits intoldc-developers:masterfrom Jan 23, 2025
Merged
gen: fix control-flow protection attribute marking#4828kinke merged 2 commits intoldc-developers:masterfrom
kinke merged 2 commits intoldc-developers:masterfrom
Conversation
... the module attribute to avoid LLVM assertions if specified module attribute already exists
liushuyu
force-pushed
the
fix-cf-attr-marking
branch
from
c7eb5a0 to
b8a9e9e
Compare
kinke
approved these changes
Jan 23, 2025
Member
|
Thx! [Btw, the PR number for the changelog ref can be guessed as |
Contributor
Author
Thanks for the tip! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes control-flow protection attribute marking by explicitly replacing the old values to avoid an LLVM assertion.
This can happen when compiling multiple D source files in one command line invocation.