GHA: Integrate Alpine musl job in main workflow by kinke · Pull Request #4826 · ldc-developers/ldc

kinke · 2025-01-18T22:45:50Z

Incl. prebuilt package etc.

…t.curl] Incl. the Phobos test runner, and dub.

JohanEngelen · 2025-01-19T18:31:15Z

cool that you are working on this!

kinke · 2025-01-19T22:39:42Z

Okay, should be ready now, after lots of trial & error runs, as usual for these CI MRs. I guess adding a musl AArch64 job as follow-up would be pretty trivial.

Some notes:

Preliminary runs with Alpine v3.21 and LLVM 19 exhibited LTO problems IIRC. So sticking with v3.20 / LLVM 17 for now.
I couldn't find an Alpine package with static LLD libs. So no LDC_WITH_LLD / -link-internally support.
The bundled ldc-prof{data,gen} tools aren't linked with -static, so depend on musl .so. That would require more CMake fiddling.
std.net.curl support depends on loading libcurl dynamically, so doesn't work (at runtime) with fully static executables. So bundled dub and reggae depend on musl .so as well (not linked with -Xcc=-static).
- The bundled ldc-build-runtime tool is fully static, so won't be able to download the source zip automatically. Again, would require more CMake fiddling.

JohanEngelen · 2025-01-19T23:17:03Z

Very cool! Let's fix the static linking later.

JohanEngelen · 2025-01-19T23:21:20Z

runtime/druntime/test/shared/src/finalize.d

        assert(0);
-    if (finalizeCounter != 4)
-        assert(0);
+    version (darwin)


nitpick, replace darwin with OSX because it is more common throughout the source code.

Yeah I know it's deprecated (unfortunately), but it's more convenient than the usual

ldc/runtime/druntime/src/core/demangle.d

Lines 15 to 22 in 9de21fd

version (OSX)

version = Darwin;

else version (iOS)

version = Darwin;

else version (TVOS)

version = Darwin;

else version (WatchOS)

version = Darwin;

which would be required for the other Apple platforms too. There are 3 existing version (darwin) usages for this shared druntime integration test, so I added the 4th one, out of laziness of course. ;)

JohanEngelen · 2025-01-19T23:23:48Z

.github/workflows/main.yml

+              -DCOMPILER_RT_LIBDIR_OS=linux
+              -DLDC_INSTALL_LLVM_RUNTIME_LIBS_ARCH=x86_64
+              -DTEST_COMPILER_RT_LIBRARIES="profile;lsan;asan;msan;fuzzer"
+              -DCMAKE_EXE_LINKER_FLAGS=-static-libstdc++


perhaps it is as simple as -DCMAKE_EXE_LINKER_FLAGS="-static-libstdc++;-static" to get fully statically linked ldc_profgen (cpp-only executables) ? I'm OK to leave as is for now.

Yes that would include the 2 pure C++ LLVM tools, but unfortunately also the static Phobos test runner, where the std.net.curl unittests then fail...

And D_LINKER_ARGS apply to all D executables built via build_d_executable() (now for LDC_LINK_MANUALLY=OFF too, where it was previously ignored). And that unfortunately also includes the ldc-build-runtime tool. Edit: But no druntime/Phobos test runners, they are pure C executables (in CMake terms).

So I think we need a dedicated CMake option for fully-static linking (on Posix), adding -static for suited executables only (no ldc-build-runtime, but the PGO LLVM tools).

Okay I've pushed a commit to that effect, and now all but dub/reggae/ldc-build-runtime executables are fully static.

kinke · 2025-01-19T23:43:45Z

Btw, I was surprised that I could link & run a Phobos-hello-world on my Ubuntu 24 box - with the bundled compiler, druntime and Phobos targeting a musl triple (edit: and my system cc for linking targeting glibc). No idea if that's just lucky or whether musl is a strict compatible subset of glibc API-wise (edit: well, the libc API required from druntime and Phobos at least).

…tests

kinke force-pushed the gha_musl branch 8 times, most recently from fb64457 to 969402a Compare January 19, 2025 01:33

kinke changed the title ~~GHA main: Add Alpine musl job~~ GHA: Integrate Alpine musl job in main workflow Jan 19, 2025

kinke force-pushed the gha_musl branch 4 times, most recently from 3f95f9b to 83cab98 Compare January 19, 2025 03:08

GHA: Integrate Alpine musl job in main workflow

adabc2f

Incl. prebuilt package etc.

kinke force-pushed the gha_musl branch from 83cab98 to adabc2f Compare January 19, 2025 03:47

kinke marked this pull request as ready for review January 19, 2025 04:17

kinke requested a review from JohanEngelen January 19, 2025 04:17

JohanEngelen and others added 2 commits January 19, 2025 15:10

Enable user-configuration of LLVM static/shared linking

76531bd

GHA Alpine: Link LLVM statically

4f51525

kinke force-pushed the gha_musl branch 3 times, most recently from 83539fc to c3f00ed Compare January 19, 2025 16:00

GHA Alpine: Link remaining lib{zstd,z,c} statically too

8165790

kinke force-pushed the gha_musl branch 3 times, most recently from c9122cd to 62905ee Compare January 19, 2025 18:11

[overcome problem of fully static executables not working with std.ne…

094ab42

…t.curl] Incl. the Phobos test runner, and dub.

kinke force-pushed the gha_musl branch from 62905ee to 094ab42 Compare January 19, 2025 18:18

kinke force-pushed the gha_musl branch from 0bf4167 to 243d1b8 Compare January 19, 2025 19:15

kinke force-pushed the gha_musl branch 2 times, most recently from 0e98a19 to 2df74c9 Compare January 19, 2025 20:12

GHA Alpine: include shared druntime+Phobos too

768759b

kinke force-pushed the gha_musl branch from 2df74c9 to 768759b Compare January 19, 2025 20:41

[add changelog entry]

9adc6b6

JohanEngelen reviewed Jan 19, 2025

View reviewed changes

JohanEngelen approved these changes Jan 19, 2025

View reviewed changes

This was referenced Jan 19, 2025

Does it become necessary to add more arch targets? kassane/alpine-ldc2-docker#3

Open

Add alpine-musl tarball kassane/ldcup#3

Closed

kinke added 2 commits January 20, 2025 02:06

CMake: Add LDC_FULLY_STATIC option

f89fc19

druntime: Refactor common isDcloseNoop logic in 'shared' integration …

dd9bf83

…tests

kassane mentioned this pull request Jan 27, 2025

D lang support chimera-linux/cports#2394

Closed

kinke merged commit c68bff1 into ldc-developers:master Jan 27, 2025

kinke deleted the gha_musl branch January 27, 2025 21:51

This was referenced Jan 30, 2025

ldcup: static-binary need libcurl (musl) kassane/ldcup#5

Closed

Alpine Linux images dlang-dockerized/packaging#10

Open

kinke mentioned this pull request May 12, 2025

musl CI: link LLVM statically (and everything else too) #4699

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GHA: Integrate Alpine musl job in main workflow#4826

GHA: Integrate Alpine musl job in main workflow#4826
kinke merged 9 commits intoldc-developers:masterfrom
kinke:gha_musl

kinke commented Jan 18, 2025 •

edited

Loading

Uh oh!

JohanEngelen commented Jan 19, 2025

Uh oh!

kinke commented Jan 19, 2025

Uh oh!

JohanEngelen commented Jan 19, 2025

Uh oh!

JohanEngelen Jan 19, 2025

Uh oh!

kinke Jan 19, 2025

Uh oh!

JohanEngelen Jan 19, 2025

Uh oh!

kinke Jan 19, 2025

Uh oh!

kinke Jan 19, 2025 •

edited

Loading

Uh oh!

kinke Jan 20, 2025

Uh oh!

kinke commented Jan 19, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	version (OSX)
	version = Darwin;
	else version (iOS)
	version = Darwin;
	else version (TVOS)
	version = Darwin;
	else version (WatchOS)
	version = Darwin;

Uh oh!

Conversation

kinke commented Jan 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JohanEngelen commented Jan 19, 2025

Uh oh!

kinke commented Jan 19, 2025

Uh oh!

JohanEngelen commented Jan 19, 2025

Uh oh!

JohanEngelen Jan 19, 2025

Choose a reason for hiding this comment

Uh oh!

kinke Jan 19, 2025

Choose a reason for hiding this comment

Uh oh!

JohanEngelen Jan 19, 2025

Choose a reason for hiding this comment

Uh oh!

kinke Jan 19, 2025

Choose a reason for hiding this comment

Uh oh!

kinke Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kinke Jan 20, 2025

Choose a reason for hiding this comment

Uh oh!

kinke commented Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kinke commented Jan 18, 2025 •

edited

Loading

kinke Jan 19, 2025 •

edited

Loading

kinke commented Jan 19, 2025 •

edited

Loading