Upgrade frontend & libs to v2.110 by kinke · Pull Request #4707 · ldc-developers/ldc

kinke · 2024-07-16T14:48:22Z

No description provided.

merge stable

…ements without error

fix issue24534 : goto can skip declarations in labeled statements without error Signed-off-by: Nicholas Wilson <[email protected]> Merged-on-behalf-of: Nicholas Wilson <[email protected]>

Part of the effort to extract semantic analysis code from the AST code. Co-authored-by: Alex Muscar <[email protected]>

Get rid of obsolete OMF support Signed-off-by: Nicholas Wilson <[email protected]> Merged-on-behalf-of: Nicholas Wilson <[email protected]>

Get rid of obsolete `{C,Cpp}Runtime_DigitalMars` special cases Signed-off-by: Dennis <[email protected]> Signed-off-by: Nicholas Wilson <[email protected]> Merged-on-behalf-of: Nicholas Wilson <[email protected]>

The 22 integration tests came with a mix of removing only ROOT (generated/OS/BUILD/MODEL) or GENERATED (generated) subdirs as part of their `make clean`. And running `make clean` in the druntime dir only cleaned up the default BUILD=release variant, while running `make unittest` without explicit BUILD type includes running the integration tests in both debug and release variants. Streamline/fix this to always cleaning up ROOT, and running `make clean` in both variants when running druntime's `make clean`.

…rray key type

merge stable

…dlang/dmd!16531) Co-authored-by: Alex Muscar <[email protected]>

…ll candidates (dlang/dmd!15572)

Co-authored-by: Alex Muscar <[email protected]>

kinke · 2024-07-16T18:03:36Z

Great, just one problem for new runnable_cxx/testbitfields.d, possibly the same as #4646.

kinke · 2024-07-19T18:41:51Z

Interesting, another bit fields problem remaining, on Linux AArch64 only, working with Apple-clang on arm64 though; probably a frontend problem, needing more special cases:

1837: Test 'runnable_cxx/testbitfields.d' failed. The logged output:
1837: /tmp/cirrus-ci-build/../clang/bin/clang++ -c runnable_cxx/extra-files/testbitfields_cpp.cpp -o ../../../build/dmd-testsuite-debug/runnable_cxx/d/testbitfields_cpp.cpp.o -std=c++11
1837: /tmp/build/bin/ldmd2 -conf= -m64 -Irunnable_cxx -g -link-defaultlib-debug -L-lstdc++ -L--no-demangle  -od../../../build/dmd-testsuite-debug/runnable_cxx/d -of../../../build/dmd-testsuite-debug/runnable_cxx/d/testbitfields_0  runnable_cxx/testbitfields.d runnable_cxx/extra-files/testbitfields_importc.c ../../../build/dmd-testsuite-debug/runnable_cxx/d/testbitfields_cpp.cpp.o 
1837: ../../../build/dmd-testsuite-debug/runnable_cxx/d/testbitfields_0  --DRT-testmode=run-main
1837: Struct S16 has different bitfield layout for C and D:
1837:   D: size=4 align=1
1837:   C: size=4 align=4
1837: Struct S18 has different bitfield layout for C and D:
1837:   D: size=9 align=1
1837:   C: size=16 align=8
1837:   char a:
1837:     D: FF000000 00000000 00
1837:     C: FF000000 00000000 00000000 00000000
1837:   char b:
1837:     D: 00000000 00000000 FF
1837:     C: 00000000 00000000 FF000000 00000000

kinke · 2024-07-19T22:30:36Z

Oh WTF:

struct S16 { int :32; };
struct S18 { char a; long long :0; char b; };

static_assert(alignof(S16) == 1); // 4 on non-Apple AArch64
static_assert(alignof(S18) == 1); // 8 on non-Apple AArch64

It works fine for arm64-apple-macos and riscv64-linux-gnu, x86 etc., but not for aarch64-linux-gnu and aarch64-freebsd. So looks like some AArch64 special case, where anonymous and 0-length bitfields do contribute to the aggregate alignment, and Apple went with a simpler/standard approach. I've checked this with clang v18.1.0, and latest stable AArch64 gcc on godbolt.org.

This appears to be handled in https://github.com/dlang/dmd/blob/6c826179ad5eec50b0bc40411acce8f7053e333f/compiler/src/dmd/dsymbolsem.d#L7176-L7193, possibly requiring a new BitFieldStyle enum member.

kinke · 2024-07-20T10:54:56Z

Okay, spec is here: https://github.com/ARM-software/abi-aa/blob/main/aapcs64/aapcs64.rst#1018bit-fields

The container type contributes to the alignment of the containing aggregate in the same way a plain (not bit-field) member of that type would, without exception for zero-sized or anonymous bit-fields.

Note

The C++ standard states that an anonymous bit-field is not a member, so it is unclear whether or not an anonymous bit-field of non-zero size should contribute to an aggregate’s alignment. Under this ABI it does.

tim-dlang · 2024-07-20T13:24:14Z

The layout for Linux armv7 is currently also wrong. Interestingly Apple seems to behave the same as Linux for armv7 and only aarch64 is different:

for t in aarch64-apple-darwin aarch64-unknown-linux-gnu \
  armv7k-apple-watchos armv7s-apple-ios armv7-unknown-linux-gnueabi
do
  echo ============ $t ============
  clang test.c -Xclang -fdump-record-layouts -c --target="$t" \
    | sed -n "/Dumping AST/,/^$/p"
done

============ aarch64-apple-darwin ============
*** Dumping AST Record Layout
         0 | struct S18
         0 |   char a
       8:- |   long long 
         8 |   char b
           | [sizeof=9, align=1]

============ aarch64-unknown-linux-gnu ============
*** Dumping AST Record Layout
         0 | struct S18
         0 |   char a
       8:- |   long long 
         8 |   char b
           | [sizeof=16, align=8]

============ armv7k-apple-watchos ============
*** Dumping AST Record Layout
         0 | struct S18
         0 |   char a
       8:- |   long long 
         8 |   char b
           | [sizeof=16, align=8]

============ armv7s-apple-ios ============
*** Dumping AST Record Layout
         0 | struct S18
         0 |   char a
       4:- |   long long 
         4 |   char b
           | [sizeof=8, align=4]

============ armv7-unknown-linux-gnueabi ============
*** Dumping AST Record Layout
         0 | struct S18
         0 |   char a
       8:- |   long long 
         8 |   char b
           | [sizeof=16, align=8]

…ng (dlang/dmd!16729)

Required for 32-bit ARM, and non-Apple 64-bit ARM targets. The only difference to `Gcc_Clang` is that anonymous and 0-length bit-fields do contribute to the aggregate alignment. Caught by existing proper C interop tests in runnable_cxx/testbitfields.d on such targets. The hardcoded bad tests in runnable/{bitfieldsposix64.c,dbitfieldsposix64.d} however now fail after the fix, on such targets again.

…tion)` hook]

….110

…elect overload anymore

….110

WalterBright and others added 30 commits May 9, 2024 23:40

rename Blockx to BlockState

9935f97

Merge remote-tracking branch 'upstream/stable' into merge_stable

f233e5f

Merge pull request dlang/dmd!16468 from ibuclaw/merge_stable

cbfd8cd

merge stable

Fix Bugzilla Issue 24534 : goto can skip declarations in labeled stat…

7ea54b9

…ements without error

Merge pull request dlang/dmd!16510 from benjones/fix24534

c835b71

fix issue24534 : goto can skip declarations in labeled statements without error Signed-off-by: Nicholas Wilson <[email protected]> Merged-on-behalf-of: Nicholas Wilson <[email protected]>

Move overrides() and leastAsSpecialized() to funcsem.d (dlang/dmd!16516)

bea6733

Part of the effort to extract semantic analysis code from the AST code. Co-authored-by: Alex Muscar <[email protected]>

Get rid of obsolete CRuntime_DigitalMars special cases

c6862a5

Get rid of obsolete OMF support

ea0a843

Get rid of obsolete DMC mangling special cases

3e98a2e

Get rid of obsolete dmd.{lib,scan}omf modules

264ac43

Revise remaining 32{omf,mscoff} usages

61e13ab

Get rid of some obsolete optlink workarounds

ed27eeb

Get rid of obsolete CppRuntime_DigitalMars special cases

defdf07

Get rid of obsolete DMC special cases

ac4c3eb

Get rid of DMC workaround for the dll_cxx dshell test

c7e7f80

Merge pull request dlang/dmd!16522 from kinke/rm_omf

a3c8076

Get rid of obsolete OMF support Signed-off-by: Nicholas Wilson <[email protected]> Merged-on-behalf-of: Nicholas Wilson <[email protected]>

Merge pull request dlang/dmd!16521 from kinke/rm_cruntime_dm

28d5441

Get rid of obsolete `{C,Cpp}Runtime_DigitalMars` special cases Signed-off-by: Dennis <[email protected]> Signed-off-by: Nicholas Wilson <[email protected]> Merged-on-behalf-of: Nicholas Wilson <[email protected]>

Remove some more OMF leftovers

2fbfd65

move code_x86.d to x86

c12b4e3

Fix bugzilla issue 20243 - inout not substituted for in associative a…

890ca32

…rray key type

Merge remote-tracking branch 'upstream/stable' into merge_stable

decc4e2

Merge pull request dlang/dmd!16534 from ibuclaw/merge_stable

b670945

merge stable

Move some semantic functions from func.d to funcsem.d and typesem.d (…

eb772ea

…dlang/dmd!16531) Co-authored-by: Alex Muscar <[email protected]>

Fix Issue 24135 - Eponymous template member overloads not shown as ca…

201a072

…ll candidates (dlang/dmd!15572)

dmd.mtype: Add workaround for building with version 2.081.x

aac6223

Move checkNRVO() from func.d to funcsem.d (dlang/dmd!16536)

0fcb505

Co-authored-by: Alex Muscar <[email protected]>

make X86 a positive affirmation (dlang/dmd!16540)

3ac1ffd

redo setDefaultLibrary() (dlang/dmd!16548)

516266b

add driverParams to parseCommandLine() (dlang/dmd!16549)

a94f440

kinke added 2 commits July 16, 2024 17:52

Adapt to renamed predefined CppRuntime_* versions

4a770ba

Little Win32 mergefix for tests/dmd/runnable/test17559.d

13a0b70

kinke force-pushed the merge-2.110 branch from 8fe057c to 13a0b70 Compare July 16, 2024 15:53

kinke added 2 commits July 19, 2024 17:54

Merge remote-tracking branch 'origin/master' into merge-2.110

c271cf9

[add changelog entry]

31323df

kinke marked this pull request as ready for review July 19, 2024 16:58

kinke mentioned this pull request Jul 19, 2024

Fix bugzilla 24592 - ImportC: Bitfield layout wrong for int64 on 32-b… dlang/dmd#16590

Merged

kinke mentioned this pull request Jul 21, 2024

[stable] Prepare TargetC for ARM bit-fields special case dlang/dmd#16742

Merged

dkorpel and others added 6 commits July 22, 2024 11:00

Fix bugzilla 24337 - Segfault when printing an int[] cast from a stri…

a638c63

…ng (dlang/dmd!16729)

[refactor to `TargetC.contributesToAggregateAlignment(BitFieldDeclara…

0356e22

…tion)` hook]

Merge remote-tracking branch 'origin/dmd-rewrite-stable' into merge-2…

05e779b

….110

Bump Phobos

2844d52

Implement new TargetC::contributesToAggregateAlignment() hook

ff49df6

kinke force-pushed the merge-2.110 branch from aa6c2af to ca08071 Compare August 2, 2024 17:14

Merge remote-tracking branch 'origin/master' into merge-2.110

2463fe9

kinke force-pushed the merge-2.110 branch from ca08071 to 2463fe9 Compare August 2, 2024 17:16

RazvanN7 and others added 5 commits August 6, 2024 02:07

Fix Bugzilla Issue 24687 - [REG2.110] Cannot cast string-imports to s…

958a415

…elect overload anymore

Merge remote-tracking branch 'origin/dmd-rewrite-stable' into merge-2…

b9a82cb

….110

Bump Phobos

2e6d917

Merge remote-tracking branch 'origin/master' into merge-2.110

2c88914

Bump bundled dlang tools / dub / reggae to preliminary versions

dd8d0e1

kinke enabled auto-merge August 10, 2024 17:43

kinke merged commit 6bd5d9a into ldc-developers:master Aug 10, 2024

kinke deleted the merge-2.110 branch August 10, 2024 19:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade frontend & libs to v2.110#4707

Upgrade frontend & libs to v2.110#4707
kinke merged 108 commits intoldc-developers:masterfrom
kinke:merge-2.110

kinke commented Jul 16, 2024

Uh oh!

kinke commented Jul 16, 2024

Uh oh!

kinke commented Jul 19, 2024

Uh oh!

kinke commented Jul 19, 2024 •

edited

Loading

Uh oh!

kinke commented Jul 20, 2024

Uh oh!

tim-dlang commented Jul 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

Uh oh!

Conversation

kinke commented Jul 16, 2024

Uh oh!

kinke commented Jul 16, 2024

Uh oh!

kinke commented Jul 19, 2024

Uh oh!

kinke commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kinke commented Jul 20, 2024

Uh oh!

tim-dlang commented Jul 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

kinke commented Jul 19, 2024 •

edited

Loading