skip attribute with empty name#4
Conversation
jsumners
left a comment
jsumners
left a comment
There was a problem hiding this comment.
This PR is fantastic. I get the impression it wasn't too difficult to figure any of the details and get them implemented.
Thinking a bit more about this, I think it would be better to make this warning fire each time an empty attribute type is attempted. The single warning is likely to get lost in the noise, and we want people to be aware of the missing data. What do you think?
In order to accomplish that, we need to bump the minimum version of process-warning in the dependencies list and apply the suggested change.
|
@ahaenggli do you have any thoughts on the PR review? |
Co-authored-by: James Sumners <[email protected]>
|
I agree that making the warning fire each time an empty attribute type is attempted is a really good idea. This will make it easier to identify the affected clients and potentially fix any related queries. |
2 participants
This should resolve #867.
The
search-request.jsfile has been changed so that empty attribute names are skipped while a corresponding warning is emitted.