Builder: make it immutable#979
Merged
Merged
Conversation
Ocramius
requested changes
Nov 17, 2022
Ocramius
approved these changes
Nov 17, 2022
lcobucci
reviewed
Dec 19, 2022
lcobucci
left a comment
Owner
There was a problem hiding this comment.
Implementation looks good and it's great no signature had to be changed.
Let's document the change (also on the upgrading guide) and it's good to go. Thanks for helping out!
Slamdunk
force-pushed
the
immutable_builder
branch
from
December 20, 2022 07:33
ed26c26 to
b626f20
Compare
Slamdunk
commented
Dec 20, 2022
Ocramius
approved these changes
Dec 20, 2022
Owner
|
I'll run the BC-break check locally against my PR that implements baseline to it and I believe we can merge this soon. Since we're making the builder immutable, there's also no reason for having the "builder factory" on the configuration object. I'd say we can easily deprecate it on v5 and remove it on v6. I'll implement that on a separate PR. |
Owner
$ ../../ocramius/bc-check/bin/roave-backward-compatibility-check --from=origin/5.0.x
## 🇷🇺 Российским гражданам
В Украине сейчас идет война. Силами РФ наносятся удары по гражданской инфраструктуре в [Харькове][1], [Киеве][2], [Чернигове][3], [Сумах][4], [Ирпене][5] и десятках других городов. Гибнут люди - и гражданское население, и военные, в том числе российские призывники, которых бросили воевать. Чтобы лишить собственный народ доступа к информации, правительство РФ запретило называть войну войной, закрыло независимые СМИ и принимает сейчас ряд диктаторских законов. Эти законы призваны заткнуть рот всем, кто против войны. За обычный призыв к миру сейчас можно получить несколько лет тюрьмы.
Не молчите! Молчание - знак вашего согласия с политикой российского правительства.
**Вы можете сделать выбор НЕ МОЛЧАТЬ.**
---
## 🇺🇸 To people of Russia
There is a war in Ukraine right now. The forces of the Russian Federation are attacking civilian infrastructure in [Kharkiv][1], [Kyiv][2], [Chernihiv][3], [Sumy][4], [Irpin][5] and dozens of other cities. People are dying – both civilians and military servicemen, including Russian conscripts who were thrown into the fighting. In order to deprive its own people of access to information, the government of the Russian Federation has forbidden calling a war a war, shut down independent media and is passing a number of dictatorial laws. These laws are meant to silence all those who are against war. You can be jailed for multiple years for simply calling for peace.
Do not be silent! Silence is a sign that you accept the Russian government's policy.
**You can choose NOT TO BE SILENT.**
[1]: <https://cloudfront-us-east-2.images.arcpublishing.com/reuters/P7K2MSZDGFMIJPDD7CI2GIROJI.jpg> "Kharkiv under attack"
[2]: <https://gdb.voanews.com/01bd0000-0aff-0242-fad0-08d9fc92c5b3_cx0_cy5_cw0_w1023_r1_s.jpg> "Kyiv under attack"
[3]: <https://ichef.bbci.co.uk/news/976/cpsprodpb/163DD/production/_123510119_hi074310744.jpg> "Chernihiv under attack"
[4]: <https://www.youtube.com/watch?v=8K-bkqKKf2A> "Sumy under attack"
[5]: <https://cloudfront-us-east-2.images.arcpublishing.com/reuters/K4MTMLEHTRKGFK3GSKAT4GR3NE.jpg> "Irpin under attack"
#StandWithUkraine
Using "/home/lcobucci/projects/libs/jwt/.roave-backward-compatibility-check.json" as configuration file
Comparing from a7f5ad6d29ebf86dd639ed4e70112c9da7df5c5e to d53d7a5c4344277f4bb43fd17b496596b7dcd0f0...
Installing dependencies from lock file
Verifying lock file contents can be installed on current platform.
Package operations: 2 installs, 0 updates, 0 removals
- Installing psr/clock (1.0.0): Extracting archive
- Installing lcobucci/clock (3.0.0): Extracting archive
1 package you are using is looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
Installing dependencies from lock file
Verifying lock file contents can be installed on current platform.
Package operations: 2 installs, 0 updates, 0 removals
- Installing psr/clock (1.0.0): Extracting archive
- Installing lcobucci/clock (3.0.0): Extracting archive
1 package you are using is looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
No backwards-incompatible changes detectedLGTM 👍 |
lcobucci
force-pushed
the
immutable_builder
branch
from
February 21, 2023 19:50
b626f20 to
c4f5d69
Compare
lcobucci
approved these changes
Feb 21, 2023
3 tasks
This was referenced Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #977