Make testing less painful#967
Merged
Merged
Conversation
Having two tests suites for such a small library doesn't make much sense to me anymore. It's much simpler to execute and maintain a single one. Signed-off-by: Luís Cobucci <[email protected]>
We're only using HTTP URIs on tests this is no security issue but an inspection from PHPStorm is adding some annoying warnings for these. This replaces everything to make that inspection happier =P Signed-off-by: Luís Cobucci <[email protected]>
Signed-off-by: Luís Cobucci <[email protected]>
We just don't use its functionality. Signed-off-by: Luís Cobucci <[email protected]>
We only have one test case that mocks the file system and several that are actually reading files. This removes mocking for the sake of simplicity. Signed-off-by: Luís Cobucci <[email protected]>
We've missed those ones on previous versions... Signed-off-by: Luís Cobucci <[email protected]>
Making things a bit more explicit. Signed-off-by: Luís Cobucci <[email protected]>
We were making things much more complicated than needed, also causing potential issues if/when behaviour is overridden. This removes PHPUnit Mock from the setup, simplifying everything. Signed-off-by: Luís Cobucci <[email protected]>
Signed-off-by: Luís Cobucci <[email protected]>
Being very specific regarding what's covered helps on a few things but we took things a bit too far in this project, to the point that it isn't that productive. This is an attempt to simplify things a bit. Signed-off-by: Luís Cobucci <[email protected]>
It seems like better reflection doesn't support this syntax, which always cause the BC-break check to report issues. Signed-off-by: Luís Cobucci <[email protected]>
lcobucci
force-pushed
the
make-testing-less-painful
branch
from
November 4, 2022 21:38
fb05975 to
989c3f7
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a big refactor of the test suite, doing some small bc-breaks to simplify the codebase.
BC-breaks: