Skip to content

Remove empty Signer, empty Key, empty Signature, empty strings#939

Merged
lcobucci merged 9 commits into
lcobucci:5.0.xfrom
Slamdunk:no_empty
Nov 8, 2022
Merged

Remove empty Signer, empty Key, empty Signature, empty strings#939
lcobucci merged 9 commits into
lcobucci:5.0.xfrom
Slamdunk:no_empty

Conversation

@Slamdunk

@Slamdunk Slamdunk commented Oct 12, 2022 •
edited by lcobucci
Loading

Copy link
Copy Markdown
Collaborator

Addresses #937 for v5.

This PR removes deprecated:

  1. \Lcobucci\JWT\Signer\None
  2. \Lcobucci\JWT\Signer\Key\InMemory::empty
  3. \Lcobucci\JWT\Token\Signature::fromEmptyData
  4. and as a result, \Lcobucci\JWT\Configuration::forUnsecuredSigner

This PR is blocked by #936 and will be marked as ready if and when #936 is merged.

Until then, you can better browse the diff comparing this to #936: Slamdunk/jwt@non_empty_string...no_empty

[BC] REMOVED: Method Lcobucci\JWT\Configuration::forUnsecuredSigner() was removed
[BC] REMOVED: Class Lcobucci\JWT\Signer\None has been deleted
[BC] REMOVED: Method Lcobucci\JWT\Signer\Key\InMemory::empty() was removed

@Slamdunk Slamdunk added this to the 5.0.0 milestone Oct 12, 2022
Ocramius
Ocramius approved these changes Oct 12, 2022
View reviewed changes
Comment thread src/Decoder.php
Comment thread src/Signer/None.php
@Slamdunk

Slamdunk commented Nov 4, 2022

Copy link
Copy Markdown
Collaborator Author

@lcobucci I'll rebase this PR and make it ready for review next week

@Slamdunk
Slamdunk marked this pull request as ready for review November 7, 2022 11:21
Slamdunk
Slamdunk commented Nov 7, 2022
View reviewed changes
Comment thread src/Token/Parser.php
@Slamdunk Slamdunk changed the title Remove empty Signer, empty Key and empty Signature Remove empty Signer, empty Key, empty Signature, empty strings Nov 7, 2022
@Slamdunk Slamdunk mentioned this pull request Nov 7, 2022
Closed
@Slamdunk

Slamdunk commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator Author

Sorry for not the cleanest way of doing it, but after the mega refactor of #967 it was tricky to get the two PR separated.

I've rebased this and merged #936 here, as well as expanding non-empty-string basically everywhere.

Slamdunk
Slamdunk commented Nov 7, 2022
View reviewed changes
Comment thread composer.json
@Slamdunk
Slamdunk requested review from Ocramius and lcobucci November 7, 2022 11:54
Ocramius
Ocramius approved these changes Nov 7, 2022
View reviewed changes

@Ocramius Ocramius left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most excellent! Thanks @Slamdunk!

Comment thread src/Encoding/JoseEncoder.php
@Ocramius Ocramius assigned Ocramius and lcobucci and unassigned Ocramius Nov 7, 2022
lcobucci
lcobucci reviewed Nov 7, 2022
View reviewed changes
Comment thread src/Signer/Blake2b.php
lcobucci
lcobucci reviewed Nov 7, 2022
View reviewed changes
Comment thread src/Signer/Eddsa.php
lcobucci
lcobucci reviewed Nov 7, 2022
View reviewed changes
Comment thread tests/ConfigurationTest.php
@lcobucci
lcobucci merged commit 0aa6537 into lcobucci:5.0.x Nov 8, 2022
@Slamdunk
Slamdunk deleted the no_empty branch November 8, 2022 09:14
@lcobucci

lcobucci commented Nov 8, 2022

Copy link
Copy Markdown
Owner

Thanks @Slamdunk!

@Slamdunk Slamdunk mentioned this pull request Nov 14, 2022
Closed
@hamrak hamrak mentioned this pull request Apr 29, 2023
Merged
@Slamdunk Slamdunk mentioned this pull request Jul 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ocramius Ocramius Ocramius approved these changes
@lcobucci lcobucci lcobucci approved these changes

Assignees

@lcobucci lcobucci

Labels

BC-break Improvement

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Slamdunk @lcobucci @Ocramius