Deprecate empty Signer, empty Key and empty Signature#938
Merged
Conversation
Ocramius
approved these changes
Oct 11, 2022
Collaborator
Author
|
BTW, yes I know what https://www.rfc-editor.org/rfc/rfc7519#section-8 says:
Screw that |
Collaborator
|
That would certainly make @paragonie happy 👍 |
Owner
lcobucci
force-pushed
the
no_empty_please
branch
from
November 4, 2022 21:20
6f9389e to
3388430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #937 for
v4.This PR deprecates:
\Lcobucci\JWT\Signer\None\Lcobucci\JWT\Signer\Key\InMemory::empty\Lcobucci\JWT\Token\Signature::fromEmptyData\Lcobucci\JWT\Configuration::forUnsecuredSignerThe likelyhood of them being misused are too high.
If someone needs them, they can implement it by themself.