Skip to content

Make test assertion more strict#931

Merged
Ocramius merged 1 commit into
lcobucci:5.0.xfrom
peter279k:improve_assertions
Oct 1, 2022
Merged

Make test assertion more strict#931
Ocramius merged 1 commit into
lcobucci:5.0.xfrom
peter279k:improve_assertions

Conversation

@peter279k

Copy link
Copy Markdown
Contributor

Changed log

  • It should use the assertSame to make assert equals strict.

@Ocramius Ocramius left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius self-assigned this Oct 1, 2022
@Ocramius Ocramius added this to the 5.0.0 milestone Oct 1, 2022
@Ocramius
Ocramius merged commit 0b66124 into lcobucci:5.0.x Oct 1, 2022
@lcobucci lcobucci changed the title Improve assert equals Make test assertion more strict Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants