Skip to content

PHP Version constraint: stick to tested versions only#880

Merged
lcobucci merged 4 commits into
5.0.xfrom
Slamdunk-patch-1
Aug 23, 2022
Merged

PHP Version constraint: stick to tested versions only#880
lcobucci merged 4 commits into
5.0.xfrom
Slamdunk-patch-1

Conversation

@Slamdunk

@Slamdunk Slamdunk commented Aug 23, 2022

Copy link
Copy Markdown
Collaborator

PHP doesn't follow SemVer, so we should provide support only for tested PHP versions

@Slamdunk Slamdunk added this to the 5.0.0 milestone Aug 23, 2022
@Slamdunk
Slamdunk requested review from Ocramius and lcobucci August 23, 2022 08:41
Ocramius
Ocramius requested changes Aug 23, 2022
View reviewed changes

@Ocramius Ocramius left a comment •
edited by Slamdunk
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we can add PHP 8.2 at this stage, since it is stable-ish.

Remember to:

  1. define config.platform.php to help dependabot/etc in upgrades
  2. update composer.lock to reflect the current composer.json

@Slamdunk

Slamdunk commented Aug 23, 2022

Copy link
Copy Markdown
Collaborator Author
  1. define config.platform.php to help dependabot/etc in upgrades

Can you elaborate a bit please? Can't find any doc about it 🤔

Ocramius
Ocramius reviewed Aug 23, 2022
View reviewed changes
Comment thread composer.json
@Ocramius

Ocramius commented Aug 23, 2022

Copy link
Copy Markdown
Collaborator
  1. define config.platform.php to help dependabot/etc in upgrades

Can you elaborate a bit please? Can't find any doc about it thinking

If we declare {"require": {"php": "~8.1.0 || ~8.2.0"}}, then @dependabot will pick up packages compatible with PHP 8.2.0 only (at some point).

To work around this, we can declare {"config": {"platform": {"php": "8.1.99"}}} to force Composer's SAT logic to always pick a dependency set that is compatible with PHP 8.1.x, while running composer update.

@Slamdunk
Define minumim supported PHP version as platform requirement to ensur…
1f8e91a 
…e future upgrades are always going to be backward compatible
@Slamdunk

Slamdunk commented Aug 23, 2022

Copy link
Copy Markdown
Collaborator Author

{"config": {"platform": {"php": "8.1.99"}}}

Ah, LoL, yes, I was looking for a config.platform.php file 🤦

Ocramius
Ocramius approved these changes Aug 23, 2022
View reviewed changes

@Ocramius Ocramius left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, letting @lcobucci call the shots though

lcobucci
lcobucci approved these changes Aug 23, 2022
View reviewed changes

@lcobucci lcobucci left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@lcobucci
lcobucci merged commit 2483e07 into 5.0.x Aug 23, 2022
@lcobucci
lcobucci deleted the Slamdunk-patch-1 branch August 23, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ocramius Ocramius Ocramius approved these changes
@lcobucci lcobucci lcobucci approved these changes

Assignees

No one assigned

Labels

Improvement

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Slamdunk @Ocramius @lcobucci