Skip to content

fix typo : you must create a new token builder,#879

Merged
Slamdunk merged 1 commit into
4.3.xfrom
unknown repository
Aug 23, 2022
Merged

fix typo : you must create a new token builder,#879
Slamdunk merged 1 commit into
4.3.xfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Aug 22, 2022

Copy link
Copy Markdown

There seemed to be a typo error with the introduction of issuing tokens.

@Slamdunk
Slamdunk changed the base branch from 5.0.x to 4.3.x August 23, 2022 05:49
@Slamdunk Slamdunk added this to the 4.3.0 milestone Aug 23, 2022
@Slamdunk
Slamdunk merged commit 5a97b2b into lcobucci:4.3.x Aug 23, 2022
@lcobucci

lcobucci commented Aug 23, 2022

Copy link
Copy Markdown
Owner

@Slamdunk I'm not planning to have a 4.3.0 (the branch was create via automation and I forgot to remove it), I'm dropping the deprecated components and tweaking minor things to go with 5.0.0 ASAP

@Slamdunk

Copy link
Copy Markdown
Collaborator

Ok, sorry didn't know that. How should we handle the merge up into 5.0.x then?

@Ocramius

Copy link
Copy Markdown
Collaborator

@Slamdunk manually, at this point?

@lcobucci should we delete 4.3.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants