Mark all classes as readonly#1091
Merged
Merged
Conversation
lcobucci
reviewed
Dec 4, 2024
lcobucci
reviewed
Dec 4, 2024
lcobucci
reviewed
Dec 4, 2024
lcobucci
approved these changes
Dec 4, 2024
lcobucci
left a comment
lcobucci
left a comment
Owner
There was a problem hiding this comment.
The changes are good, thanks.
I personally don't like the factory method Builder::new() but it's a necessary evil to ensure that we don't have people injecting crazy stuff there.
Collaborator
Author
This concern is easy to address with new |
Slamdunk
force-pushed
the
readonly_classes
branch
2 times, most recently
from
January 29, 2025 07:08
55638e5 to
c1daba7
Compare
Slamdunk
force-pushed
the
readonly_classes
branch
from
January 29, 2025 07:09
c1daba7 to
7e76d0e
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1086
This PR needs a new
6.0.xbranch