Remove requirement of core PHP extensions#1009
Closed
cedric-anne wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Lint job would be fixed by maglnet/ComposerRequireChecker#399. |
Collaborator
Ocramius
added
Incomplete
Waiting for Information
Dependencies
Ocramius
requested changes
Apr 22, 2023
Ocramius
left a comment
Ocramius
left a comment
Collaborator
There was a problem hiding this comment.
composer.lock needs updating too
lcobucci
added a commit
that referenced
this pull request
Nov 4, 2023
This was raised by @cedric-anne but I didn't manage to merge it in time. More info: #1009 Authored by: Cédric Anne Signed-off-by: Luís Cobucci <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PHP 7.4,
ext-hashis part of PHP core and cannot be disabled (see https://www.php.net/manual/en/hash.installation.php).Since PHP 8.0,
ext-jsonis part of PHP core and cannot be disabled (see https://www.php.net/manual/en/json.installation.php).I think they could be removed from
composer.jsonrequire section.