Support other PSR-20 implementations#1001
Merged
Merged
Conversation
Slamdunk
requested changes
Feb 22, 2023
lcobucci
force-pushed
the
use-clock-from-psr
branch
2 times, most recently
from
February 23, 2023 21:22
812ddd9 to
eb8bca5
Compare
lcobucci
force-pushed
the
use-clock-from-psr
branch
from
February 23, 2023 21:41
5c93737 to
7e23ea4
Compare
Slamdunk
approved these changes
Feb 24, 2023
This promotes better interoperability by allowing users to plug any Clock implementation that follows PSR-20 - we still fallback to lcobucci/clock. Signed-off-by: Luís Cobucci <[email protected]>
This allows users to choose which PSR-20 they want to have installed in their systems, without changing our test suite that much. Signed-off-by: Luís Cobucci <[email protected]>
Signed-off-by: Luís Cobucci <[email protected]>
lcobucci
force-pushed
the
use-clock-from-psr
branch
from
February 25, 2023 21:33
7e23ea4 to
47307cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This promotes better interoperability by allowing users to plug any Clock implementation that follows PSR-20 - we still fallback to lcobucci/clock.