keep the block filter entirely in sqlite#387
Merged
BrannonKing merged 1 commit intov19_masterfrom Apr 22, 2020
Merged
Conversation
and make it work right, fixing issue 383
Collaborator
|
We can unite filter and filter header as well? Do we need separate functions? |
Member
Author
|
Yes, the code is repetitive. Feel free to make a convenient way to pass the column name (and return type) and reuse the code. |
Member
Author
|
Did I mention how pleased I was with the amount of code that I deleted? |
Collaborator
|
What was the problem in #383 i can't reproduce it? |
Member
Author
|
#383 was a corrupt flat file. I'm not sure how he got one. I'm declaring it fixed by not using the flat file any more. |
Collaborator
|
OK, +1 from me, i've test the changes, running test as well. |
bvbfan
approved these changes
Apr 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and made it work right.
Fixes #383