Merged
Conversation
Signed-off-by: Anthony Fieroni <[email protected]>
BrannonKing
requested changes
Jul 16, 2019
| { | ||
| ClaimTrieChainFixture fixture; | ||
| fixture.setExpirationTime(3); | ||
| fixture.setExpirationForkHeight(800, 3, 800); |
Member
There was a problem hiding this comment.
I don't think this is right. Aren't those 800s supposed to be 140, the current height? What was the old behavior? I don't see that this test goes all the way to 800 increments, so I doubt it's hitting the danger zone.
Collaborator
Author
There was a problem hiding this comment.
In ClaimTrieChainFixture we don't change the consensus, so setExpirationTime was supposed to change only expiration time, since we don't have such functionality it should be
fixture.setExpirationForkHeight(consensus.nExtendedClaimExpirationForkHeight, 3, consensus.nExtendedClaimExpirationTime)
Signed-off-by: Anthony Fieroni <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anthony Fieroni [email protected]
Fixes #287