-
Notifications
You must be signed in to change notification settings - Fork 177
Improve logging by separating debug from information #144
Copy link
Copy link
Closed
Labels
type: improvementExisting (or partially existing) functionality needs to be changedExisting (or partially existing) functionality needs to be changed
Description
fDebug flag can be used for that like:
Lines 5226 to 5227 in 01a222a
| if (fDebug || (vInv.size() != 1)) | |
| LogPrint("net", "received getdata (%u invsz) peer=%d\n", vInv.size(), pfrom->id); |
It's initialized according to -debug setting:
Line 860 in 270307a
| fDebug = !mapMultiArgs["-debug"].empty(); |
Ideally it should be applied to log messages that doesn't hold information for a sysadmin, but mainly for developers, like: https://github.com/lbryio/lbrycrd/blob/master/src/claimtrie.cpp#L1927
To be updated with more examples where it should be applied after #137 gets merged as it adds more cases.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
type: improvementExisting (or partially existing) functionality needs to be changedExisting (or partially existing) functionality needs to be changed