internal fixes for intermittent test failures#3707
Merged
eukreign merged 8 commits intolbryio:masterfrom Nov 21, 2022
Merged
Conversation
eukreign
changed the title
eukreign
added
type: improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes pretty much all the work I planned to do on lbry-sdk test reliability. It should unblock more python3.9 work.
Fixes #3665
Fixes #3671
Bumping hub gets us the benefit of these fixes:
lbryio/hub#98
lbryio/hub#101
lbryio/hub#104
I also revisited #3658 because I encountered a new zlib.error "invalid window size".
I've started seeing failures like this when running tests. Something changed in the environment I think.
https://github.com/moodyjon/lbry-sdk/actions/runs/3447835647/jobs/5754426649
Successful run from 2mo ago with python 3.7.14 (failure was with 3.7.15):
https://github.com/moodyjon/lbry-sdk/actions/runs/3108575245/jobs/5038289310
Upgrade to pyinstaller==4.6 was suggested here:
pyinstaller/pyinstaller#6325