usage payment service more resilient, will continue running until funds available to pay usage fee#3668
Merged
eukreign merged 8 commits intolbryio:masterfrom Sep 20, 2022
Conversation
Change test to reproduce failure.
eukreign
approved these changes
Sep 20, 2022
Member
|
i approved this but you have to remove the |
shyba
approved these changes
Sep 20, 2022
moodyjon
force-pushed
the
test_single_server_payment
branch
from
d82de5e to
13d05d3
Compare
Contributor
Author
|
workflow_dispatch removed and exception logging tweaked: 13d05d3 |
eukreign
changed the title
eukreign
added
type: improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3663
The WalletServerPayer was receiving
asyncio.CancelledErrorfromretriable_call()becausejsonrpc_wallet_reconnect()creates a situation where the connection is totally gone.I reworked how it handles exceptions so it tolerates ConnectionError, InsufficientFundsError without exiting prematurely.
Plan to revert 4422896 which is for push button testing.