new wallet commands for importing and exporting wallets#3637
Merged
new wallet commands for importing and exporting wallets#3637
wallet commands for importing and exporting wallets#3637Conversation
eukreign
requested changes
Jul 25, 2022
Member
eukreign
left a comment
eukreign
left a comment
There was a problem hiding this comment.
is this PR ready for one final review?
Member
Author
Yes please |
eukreign
force-pushed
the
feature-walletImportExport
branch
from
5ef78d9 to
fa3ea2c
Compare
eukreign
approved these changes
Aug 1, 2022
eukreign
added
type: new feature
eukreign
changed the title
wallet commands for importing and exporting wallets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@eukreign Recommended a wallet import / output method rather than altering the behavior of sync apply. This does not force reset the wallet encrypt password with the import/export data encrypt password.
I mostly duplilcated what I thought was the relevant sync_apply test. Let me know if you think any of the test is too redundant or missing.