Skip to content

Fixes bugs on disk space management and stream recovery where finished sd blobs could go missing or "pending" or wrong timestamp#3585

Merged
shyba merged 6 commits intomasterfrom
fix_blob_db_queries
Mar 25, 2022
Merged

Fixes bugs on disk space management and stream recovery where finished sd blobs could go missing or "pending" or wrong timestamp#3585
shyba merged 6 commits intomasterfrom
fix_blob_db_queries

Conversation

@shyba
Copy link
Copy Markdown
Member

@shyba shyba commented Mar 21, 2022 •
edited
Loading

  • fixes bug where blob_clean (disk space management) would clean sd blobs from a SQL bad query
  • fix bug where added_on is 0 for all blobs except sd blob
  • change disk space management order to delete sd blobs last on both cases (seeding and normal space)
  • fix bug where stream recovery would set sd blob as 'pending' and recover again every startup while also losing status for all other blobs in a stream
  • on startup, if a blob is present but pending on db, check length and fix status

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 21, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 70.225% when pulling 200761f on fix_blob_db_queries into ad489ed on master.

@shyba shyba changed the title Fix blob db queries Fixes bugs on disk space management and stream recovery Mar 22, 2022
@shyba shyba requested a review from jackrobison March 22, 2022 00:39
@lbry-bot lbry-bot assigned jackrobison and unassigned shyba Mar 22, 2022
@shyba shyba marked this pull request as ready for review March 22, 2022 00:39
@shyba shyba force-pushed the fix_blob_db_queries branch from 7ab83cb to f38af25 Compare March 24, 2022 22:46
@shyba shyba force-pushed the fix_blob_db_queries branch from f38af25 to 200761f Compare March 24, 2022 22:51
@lbry-bot lbry-bot assigned shyba and unassigned jackrobison Mar 25, 2022
@shyba shyba merged commit e89acac into master Mar 25, 2022
@shyba shyba deleted the fix_blob_db_queries branch March 25, 2022 00:01
shyba added a commit that referenced this pull request Mar 25, 2022
@shyba
Merge pull request #3585 from lbryio/fix_blob_db_queries
cf73e45 
Fixes bugs on disk space management and stream recovery
@shyba shyba added type: bug Existing functionality is wrong or broken area: blobs/files labels Mar 28, 2022
@shyba shyba changed the title Fixes bugs on disk space management and stream recovery Fixes bugs on disk space management and stream recovery where finished sd blobs could go missing or "pending" or wrong timestamp Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackrobison jackrobison jackrobison approved these changes

Assignees

@shyba shyba

Labels

area: blobs/files type: bug Existing functionality is wrong or broken

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shyba @coveralls @jackrobison