Only announce sd blobs, stop announcing head blobs#3565
Merged
Conversation
shyba
added
type: improvement
shyba
force-pushed
the
stop_announcing_head_blob
branch
from
bf82e5c to
43dd675
Compare
jackrobison
reviewed
Feb 16, 2022
| from .migrate13to14 import do_migration | ||
| elif current == 14: | ||
| from .migrate14to15 import do_migration | ||
| elif current == 15: |
Member
There was a problem hiding this comment.
this needs to be documented as a breaking change, users will only be able to downgrade by manually editing the version file
shyba
force-pushed
the
stop_announcing_head_blob
branch
from
43dd675 to
3ee3e7f
Compare
jackrobison
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backwards-incompatible: For desktop / lbry-sdk users: this release includes a migration that increasing the database version. This usually means you can't downgrade without a backup of lbrynet.sqlite.
This should make 1 announcement per stream instead of 2.
part of #3527 but probably doesn't close it (faster hash announcer and tracker to go)