Skip to content

Add handling for stream_update to work with reposts#3537

Merged
lyoshenka merged 1 commit intomasterfrom
repost_update
Feb 8, 2022
Merged

Add handling for stream_update to work with reposts#3537
lyoshenka merged 1 commit intomasterfrom
repost_update

Conversation

@lyoshenka
Copy link
Copy Markdown
Member

fixes #2678

@lyoshenka lyoshenka requested a review from shyba January 5, 2022 16:45
# # TODO: use error from lbry.error
# raise Exception(
# f"A claim with id '{claim_id}' was found but it is not a stream claim."
# )
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably now check that the claim is either a stream or a repost

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 69.702% when pulling 7c7a0d4 on repost_update into cc829a7 on master.

@lyoshenka lyoshenka merged commit c96d1d9 into master Feb 8, 2022
@lyoshenka lyoshenka deleted the repost_update branch February 8, 2022 17:20
@jackrobison jackrobison changed the title let stream_update work on non-stream claims let stream_update work on repost claims Mar 4, 2022
@jackrobison jackrobison changed the title let stream_update work on repost claims Fix stream_update working with a repost claim Mar 4, 2022
@jackrobison jackrobison added type: improvement Existing (or partially existing) functionality needs to be changed area: wallet labels Mar 4, 2022
@jackrobison jackrobison changed the title Fix stream_update working with a repost claim Add handling for stream_update to work with reposts Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: wallet type: improvement Existing (or partially existing) functionality needs to be changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add / support APIs for updating reposts

6 participants