Skip to content

Drop dependency on cryptography library in wallet module#3534

Merged
eukreign merged 2 commits intomasterfrom
normalize_signatures
Jan 17, 2022
Merged

Drop dependency on cryptography library in wallet module#3534
eukreign merged 2 commits intomasterfrom
normalize_signatures

Conversation

@eukreign
Copy link
Copy Markdown
Member

@eukreign eukreign commented Jan 1, 2022

fixes #3532

@eukreign eukreign added area: wallet type: improvement Existing (or partially existing) functionality needs to be changed labels Jan 1, 2022
@kauffj kauffj requested a review from shyba January 5, 2022 16:07
@lbry-bot lbry-bot assigned shyba and unassigned eukreign Jan 5, 2022
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 7, 2022

Coverage Status

Coverage remained the same at 69.687% when pulling 302461b on normalize_signatures into f78e382 on master.

Comment thread lbry/wallet/bip32.py
@lbry-bot lbry-bot assigned eukreign and unassigned shyba and eukreign Jan 7, 2022
@eukreign eukreign assigned shyba and unassigned eukreign Jan 10, 2022
@lbry-bot lbry-bot assigned eukreign and unassigned shyba Jan 10, 2022
@eukreign eukreign force-pushed the normalize_signatures branch from 42cf4b4 to 302461b Compare January 17, 2022 16:08
@eukreign eukreign requested a review from shyba January 17, 2022 16:10
@lbry-bot lbry-bot assigned shyba and unassigned eukreign and shyba Jan 17, 2022
@eukreign eukreign merged commit b5ead91 into master Jan 17, 2022
@eukreign eukreign deleted the normalize_signatures branch January 17, 2022 18:38
@jackrobison jackrobison changed the title drop dependency on cryptography library in wallet module Drop dependency on cryptography library in wallet module Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: wallet type: improvement Existing (or partially existing) functionality needs to be changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

investigate: ecdsa created signatures do not validate with coincurve

3 participants