Skip to content

Deterministic channel keys#3450

Merged
eukreign merged 13 commits intomasterfrom
deterministic_channel_keys
Dec 23, 2021
Merged

Deterministic channel keys#3450
eukreign merged 13 commits intomasterfrom
deterministic_channel_keys

Conversation

@eukreign
Copy link
Copy Markdown
Member

@eukreign eukreign commented Oct 13, 2021

backwards-incompatible: Wallet server / hub operators: this changes the signature format for new and updated claims. If you update your wallet server after sdk clients have begun creating and updating claims with the new signature format you'll need to resync the wallet server and elasticsearch from a snapshot in order to correctly validate them.

fixes #1433, #1888

@eukreign eukreign force-pushed the deterministic_channel_keys branch from b274599 to 8dfa20d Compare December 13, 2021 02:43
@eukreign eukreign marked this pull request as ready for review December 13, 2021 05:31
@eukreign eukreign requested a review from jackrobison December 13, 2021 05:31
@lbry-bot lbry-bot assigned jackrobison and unassigned eukreign Dec 13, 2021
@eukreign eukreign changed the title deterministic channel keys deterministic channel keys (requires wallet server re-sync) Dec 19, 2021
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 19, 2021

Coverage Status

Coverage remained the same at 69.664% when pulling c80b30f on deterministic_channel_keys into 5eb95d7 on master.

@lyoshenka lyoshenka self-requested a review December 20, 2021 16:48
@lyoshenka lyoshenka removed their request for review December 21, 2021 14:57
@eukreign eukreign added area: claims type: improvement Existing (or partially existing) functionality needs to be changed labels Dec 21, 2021
@eukreign eukreign force-pushed the deterministic_channel_keys branch from a398f8e to c80b30f Compare December 23, 2021 00:02
@eukreign eukreign merged commit 8076000 into master Dec 23, 2021
@eukreign eukreign deleted the deterministic_channel_keys branch December 23, 2021 20:38
@jackrobison jackrobison changed the title deterministic channel keys (requires wallet server re-sync) Deterministic channel keys Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: claims type: improvement Existing (or partially existing) functionality needs to be changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deterministic channel certificates

4 participants