Cause EOF and Ctrl-D to exit the CLI #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
commented
Sep 22, 2021
| Right cmd -> evaluateCmd cmd `catchError` showFailure | ||
| where | ||
| showFailure e = liftIO $ putStrLn $ "Failed: "<> e | ||
| showFailure e = liftIO $ hPutStrLn stderr $ "Failed: "<> e |
Contributor
Author
There was a problem hiding this comment.
I also swapped some of the status and error messaging to use stderr so that stdout is more easily parseable by scripts and such. It should look exactly the same in regular terminal usage.
Owner
|
This is excellent, thank you for that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Loving the tool so far, looking into a few tweaks to help make things a bit more scriptable; I'll try to break them up into manageable chunks :)
This first one is very simple and causes hdc to respect the "EOF" input, which, in almost all CLIs (including ghci). Many folks will have Ctrl-D muscle-memory to exit things, and now it'll work :)
It also allows you to script hdc much more easily from the CLI using stdin, since you can do things like
pbpaste | hdcand it will run a query and quit. Currently it gets stuck in an infinite loop.