Skip to content

[Icon] Add SaveIcon to Sistent - #1468

Merged
saurabhraghuvanshii merged 3 commits into
layer5io:masterfrom
rishiraj38:feat/add-save-icon
May 3, 2026
Merged

saurabhraghuvanshii merged 3 commits into
layer5io:masterfrom
rishiraj38:feat/add-save-icon

Conversation

@rishiraj38

Copy link
Copy Markdown
Contributor

Notes for Reviewers

This PR fixes #1464

Signed commits

  • Yes, I signed my commits.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new SaveIcon component and exports it from the icon directory. A review comment suggests adding an explicit close command to a sub-path in the SVG data to ensure consistent rendering across different SVG engines.

Comment thread src/icons/Save/SaveIcon.tsx Resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Rishi Raj <[email protected]>
@saurabhraghuvanshii

Copy link
Copy Markdown
Member

@rishiraj38 I think you missed to include this icon in list of Icon

@rishiraj38

Copy link
Copy Markdown
Contributor Author

@rishiraj38 I think you missed to include this icon in list of Icon

src/icons/index.ts actually already contains export * from './Save';, which automatically exports the new SaveIcon I added to the Save directory.

@saurabhraghuvanshii
saurabhraghuvanshii merged commit 2c36840 into layer5io:master May 3, 2026
5 checks passed
leecalcote pushed a commit that referenced this pull request Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add SaveIcon to Sistent

2 participants