Skip to content

Feat/add launch icon - #1466

Merged
saurabhraghuvanshii merged 3 commits into
layer5io:masterfrom
rishiraj38:feat/add-launch-icon
May 3, 2026
Merged

saurabhraghuvanshii merged 3 commits into
layer5io:masterfrom
rishiraj38:feat/add-launch-icon

Conversation

@rishiraj38

Copy link
Copy Markdown
Contributor

Notes for Reviewers

This PR fixes #1462

Signed commits

  • Yes, I signed my commits.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new LaunchIcon component and integrates it into the icons library. A review comment identifies that the SVG path used for LaunchIcon appears to duplicate existing icons such as OpenInNew and ExternalLink. It is recommended to alias one of the existing icons instead of adding a new one to improve maintainability and minimize the bundle size.

Comment thread src/icons/index.ts Resolved
@saurabhraghuvanshii
saurabhraghuvanshii merged commit 5d3f2ce into layer5io:master May 3, 2026
5 checks passed
leecalcote pushed a commit that referenced this pull request Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add LaunchIcon to Sistent

2 participants