Skip to content

Commit 61619b2

Browse files
fix(contract): drop the unproven cause claim from the capability diagnostic
The closing sentence asserted host and bundle were built against different contract revisions even when the only finding was a missing capability at a matching advertised version, sending the reader to compare two numbers that agree. A known version mismatch is already named in the listed parts. Signed-off-by: Ahmed Jamil <[email protected]>
1 parent 5eeff36 commit 61619b2

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

‎src/actors/mesheryExtensionContract.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -393,9 +393,12 @@ export const describeInjectedCapabilityReport = (
393393
if (report.missingHooks.length > 0) {
394394
parts.push(`missing hooks: ${report.missingHooks.join(', ')}`);
395395
}
396+
// Deliberately no closing claim about *why* they disagree. When a version
397+
// mismatch is known it is already named above; when it is not, the host and
398+
// this bundle disagree while advertising the same version, and asserting a
399+
// version skew would send the reader to compare two numbers that match.
396400
return (
397401
`Meshery host did not satisfy the extension contract (v${MESHERY_EXTENSION_CONTRACT_VERSION}): ` +
398-
`${parts.join('; ')}. Host and extension bundle were built against different ` +
399-
'contract revisions; the features these keys back will not work.'
402+
`${parts.join('; ')}. The features these keys back will not work.`
400403
);
401404
};

0 commit comments

Comments
 (0)