Skip to content

Clean up of explicit namespace declaration#98

Merged
mgkwill merged 2 commits intolava-nc:mainfrom
bamsumit:clean_init
Nov 23, 2021
Merged

Clean up of explicit namespace declaration#98
mgkwill merged 2 commits intolava-nc:mainfrom
bamsumit:clean_init

Conversation

@bamsumit
Copy link
Copy Markdown
Contributor

@bamsumit bamsumit commented Nov 23, 2021 •
edited
Loading

  • explicit namespace declaration cleanup
  • unittests runnable from root level or anywhere in tests/
    python -m unittest

@bamsumit bamsumit linked an issue Nov 23, 2021 that may be closed by this pull request
Remove legacy __init__.py code #64
Closed
@bamsumit
Copy link
Copy Markdown
Contributor Author

bamsumit commented Nov 23, 2021

Copying PyCharm config instruction from here

  • put the 'src' directories (e.g., lava/src) of all lava repositories into the PYTHONPATH
  • Mark all 'src' directories (e.g., lava/src) as "Sources Root"
  • Mark all 'tests/lava' (NOT tests!) directories (e.g., lava/tests/lava) as "Test Sources Root"

mathisrichter
mathisrichter approved these changes Nov 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mathisrichter mathisrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mathisrichter mathisrichter added this to the Release v0.2.0 milestone Nov 23, 2021
mgkwill
mgkwill approved these changes Nov 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mgkwill mgkwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Works from the command line as @bamsumit suggested with python -m unittest and in VS Code using . as root of testing.

Thanks @bamsumit for reworking this change from a clean branch and the testing and effort!

@mgkwill mgkwill merged commit e6ba2d9 into lava-nc:main Nov 23, 2021
@bamsumit bamsumit deleted the clean_init branch November 23, 2021 23:19
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@bamsumit
Clean up of explicit namespace declaration (lava-nc#98)
b8f3d85 
* new init clean from main
* fix build and tests's inits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgkwill mgkwill mgkwill approved these changes

@mathisrichter mathisrichter mathisrichter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release v0.2.0

Development

Successfully merging this pull request may close these issues.

Remove legacy __init__.py code

3 participants

@bamsumit @mgkwill @mathisrichter