Merged
Conversation
GaboFGuerra
approved these changes
Feb 29, 2024
Contributor
GaboFGuerra
left a comment
GaboFGuerra
left a comment
There was a problem hiding this comment.
Thanks Philipp! looks good :)
phstratmann
requested review from
AlessandroPierro,
ashishrao7,
srrisbud and
tim-shea
ashishrao7
approved these changes
Feb 29, 2024
Collaborator
ashishrao7
left a comment
ashishrao7
left a comment
There was a problem hiding this comment.
Works as it should. Tested behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a spiker with 32bit messages
Also, this spiker actually has a correct definition of period. It sends its first spike after 'period' number of time steps.