Merged
Conversation
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
awintel
requested changes
Nov 18, 2021
Contributor
awintel
left a comment
awintel
left a comment
There was a problem hiding this comment.
Looks good. Just some minor comments.
… and their unittests Signed-off-by: bamsumit <[email protected]>
srrisbud
requested changes
Nov 19, 2021
Contributor
srrisbud
left a comment
srrisbud
left a comment
There was a problem hiding this comment.
There are a few changes needed. Especially the ReceiveProcess has its ProcessModels flipped.
awintel
reviewed
Nov 19, 2021
Contributor
awintel
left a comment
awintel
left a comment
There was a problem hiding this comment.
Just some additional comments
…Sudmedh's comments Signed-off-by: bamsumit <[email protected]>
drager-intel
requested changes
Nov 19, 2021
Contributor
drager-intel
left a comment
drager-intel
left a comment
There was a problem hiding this comment.
My only 2 comments are surrounding unit tests. Can we add some unit tests for the Conv Connection behavior that don't rely on Torch?
mathisrichter
requested changes
Nov 19, 2021
Contributor
mathisrichter
left a comment
mathisrichter
left a comment
There was a problem hiding this comment.
Looks great, Sumit!
- Not sure whether this is a general convention but elsewhere we use type hints in class, method, and function signatures. Maybe add an issue for that and do it later.
Contributor
This is probably clear to some due to internal conversations but the title is not descriptive and I don't see an issue for this pull. Can we please follow the process, I.E. open an issue that explains the change and have at least a minimal explanation of the work in the pull request? |
Signed-off-by: bamsumit <[email protected]>
Signed-off-by: bamsumit <[email protected]>
bamsumit
requested review from
awintel,
drager-intel,
mathisrichter and
srrisbud
Signed-off-by: bamsumit <[email protected]>
mathisrichter
requested changes
Nov 21, 2021
Signed-off-by: bamsumit <[email protected]>
mathisrichter
approved these changes
Nov 21, 2021
awintel
approved these changes
Nov 23, 2021
Contributor
awintel
left a comment
awintel
left a comment
There was a problem hiding this comment.
Nothing major except for missing indentation of function arguments that start in a new line. That makes code not very readable.
Could be fixed later but we should not leave it like that.
drager-intel
approved these changes
Nov 23, 2021
Contributor
drager-intel
left a comment
drager-intel
left a comment
There was a problem hiding this comment.
Thanks for adding a known input-output unit test of conv behavior for users w/out Torch installed! Looks good!
Signed-off-by: bamsumit <[email protected]>
srrisbud
approved these changes
Nov 24, 2021
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* Conv process implementation with unittests. Signed-off-by: bamsumit <[email protected]> * updated requirements and test inits Signed-off-by: bamsumit <[email protected]> * tweak unittests Signed-off-by: bamsumit <[email protected]> * fix merge conflict Signed-off-by: bamsumit <[email protected]> * Fix to comments, fixed lif warnings, refactored source sink processes and their unittests Signed-off-by: bamsumit <[email protected]> * flesh source/sink nomenclature. Fix overflow/underflow bug. Resolved Sudmedh's comments Signed-off-by: bamsumit <[email protected]> * New ground truth based conv implementation test * type hinting fix Signed-off-by: bamsumit <[email protected]> * removed unnecessary commented code Signed-off-by: bamsumit <[email protected]> * typehinting consistency fix: np.array -> np.ndarray Signed-off-by: bamsumit <[email protected]> * static seeds in unittest Signed-off-by: bamsumit <[email protected]> * fixes for clean init merge Signed-off-by: bamsumit <[email protected]> Co-authored-by: Risbud, Sumedh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of conv process and process models.