LIF ProcessModels: Floating and fixed point: PR attempt #2#70
Merged
srrisbud merged 23 commits intolava-nc:mainfrom Nov 18, 2021
Merged
LIF ProcessModels: Floating and fixed point: PR attempt #2#70srrisbud merged 23 commits intolava-nc:mainfrom
srrisbud merged 23 commits intolava-nc:mainfrom
Conversation
Signed-off-by: Risbud, Sumedh <[email protected]>
Signed-off-by: Risbud, Sumedh <[email protected]>
Signed-off-by: Risbud, Sumedh <[email protected]>
…created through LavaPyType Signed-off-by: Risbud, Sumedh <[email protected]>
…created through LavaPyType Signed-off-by: Risbud, Sumedh <[email protected]>
Signed-off-by: Risbud, Sumedh <[email protected]>
Signed-off-by: Risbud, Sumedh <[email protected]>
Signed-off-by: Risbud, Sumedh <[email protected]>
…>src/lava reorg) Signed-off-by: Risbud, Sumedh <[email protected]>
Signed-off-by: Risbud, Sumedh <[email protected]>
Signed-off-by: Risbud, Sumedh <[email protected]>
Signed-off-by: Risbud, Sumedh <[email protected]>
srrisbud
added
0-needs-review
…created through LavaPyType Signed-off-by: Risbud, Sumedh <[email protected]>
Signed-off-by: Risbud, Sumedh <[email protected]>
Contributor
Author
Seems like I was successful in fixing the merge issues. There are no merge conflicts anymore. |
Signed-off-by: Risbud, Sumedh <[email protected]>
mathisrichter
requested changes
Nov 18, 2021
Contributor
mathisrichter
left a comment
mathisrichter
left a comment
There was a problem hiding this comment.
Looks good in general.
The most important request from my side are unit tests for the Process Models and their dynamics.
I didn't check the changes to the tutorials.
bamsumit
approved these changes
Nov 18, 2021
Contributor
bamsumit
left a comment
bamsumit
left a comment
There was a problem hiding this comment.
Looks good to me. I didn't go through the notebooks. I guess they work ;)
Signed-off-by: Risbud, Sumedh <[email protected]>
srrisbud
commented
Nov 18, 2021
Contributor
Author
srrisbud
left a comment
srrisbud
left a comment
There was a problem hiding this comment.
Went over everything once
Contributor
|
Nice! But no unit tests for the two Process Models? |
mathisrichter
approved these changes
Nov 18, 2021
Contributor
Never mind, I overlooked all of that. Sorry! |
Contributor
|
@srrisbud the new lif unittests are really polluting the console with deprication warnings. Apparently they don't show up in /home/sshresth/lava-nc/lava/src/lava/proc/lif/models.py:24: DeprecationWarning: `np.float` is a deprecated alias for the builtin `float`. To silence this warning, use `float` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64` here.
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
a_in: PyInPort = LavaPyType(PyInPort.VEC_DENSE, np.float)
/home/sshresth/lava-nc/lava/src/lava/proc/lif/models.py:26: DeprecationWarning: `np.float` is a deprecated alias for the builtin `float`. To silence this warning, use `float` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64` here.
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
u: np.ndarray = LavaPyType(np.ndarray, np.float) |
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
…va-nc#70) * Added @tags decorator to tag ProcessModels and distinguish them Signed-off-by: Risbud, Sumedh <[email protected]> * Fixed @tags decorator after pull request review Signed-off-by: Risbud, Sumedh <[email protected]> * LIF: bit-accurate with Loihi and floating point ProcessModels Signed-off-by: Risbud, Sumedh <[email protected]> * Minor change to variable builder to support floating point variables created through LavaPyType Signed-off-by: Risbud, Sumedh <[email protected]> * Minor change to variable builder to support floating point variables created through LavaPyType Signed-off-by: Risbud, Sumedh <[email protected]> * lava -> src/lava: reorg to resolve merge conflicts Signed-off-by: Risbud, Sumedh <[email protected]> * tests -> tests/lava: reorg to resolve merge conflicts Signed-off-by: Risbud, Sumedh <[email protected]> * tests -> tests/lava: reorg to resolve merge conflicts Signed-off-by: Risbud, Sumedh <[email protected]> * Manual merge of changes from message passing refactoring (after lava->src/lava reorg) Signed-off-by: Risbud, Sumedh <[email protected]> * Loihi1SimCfg handles subProcs and tags. Tutorials 2-6 work with new LIF * Minor: builder support for float LavaPyType corrected Signed-off-by: Risbud, Sumedh <[email protected]> * LIF: incorporated code-review suggestions Signed-off-by: Risbud, Sumedh <[email protected]> * Manually merge latest lava-nc/lava:main to the personal fork:main Signed-off-by: Risbud, Sumedh <[email protected]> * Minor change to variable builder to support floating point variables created through LavaPyType Signed-off-by: Risbud, Sumedh <[email protected]> * Fixing flake8 flagged line overflows Signed-off-by: Risbud, Sumedh <[email protected]> * Fixing flake8 flagged line overflows Signed-off-by: Risbud, Sumedh <[email protected]> * LIF: changes in response to @mathisrichter's review Signed-off-by: Risbud, Sumedh <[email protected]> Co-authored-by: drager-intel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are merge conflicts. Trying to resolve these gracefully, without using the nuclear option of deleting and recreating the entire fork.