Skip to content

Minor refactoring for DelayDense/Sparse process#693

Merged
PhilippPlank merged 4 commits intomainfrom
Change-for-DelayDense
May 16, 2023
Merged

Minor refactoring for DelayDense/Sparse process#693
PhilippPlank merged 4 commits intomainfrom
Change-for-DelayDense

Conversation

@PhilippPlank
Copy link
Copy Markdown
Contributor

@PhilippPlank PhilippPlank commented May 15, 2023

Objective of pull request: The maximum delay needs to be part of the keyword arguments of the Dense process in order to use this value for the NcProcModel to determine the needed number of bits when configuring delays on Loihi 2.

This change does not affect anything else.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@PhilippPlank PhilippPlank self-assigned this May 15, 2023
@PhilippPlank PhilippPlank changed the title Change for DelayDense Minor refactoring for DelayDense/Sparse process May 15, 2023
@PhilippPlank PhilippPlank added the 1-refactor Suggestion to refactor part of the code label May 15, 2023
Copy link
Copy Markdown
Contributor

@weidel-p weidel-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PhilippPlank PhilippPlank merged commit e39a4b6 into main May 16, 2023
@PhilippPlank PhilippPlank deleted the Change-for-DelayDense branch May 16, 2023 08:20
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
* Update process.py

* Update process.py

* Update process.py

* Update process.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1-refactor Suggestion to refactor part of the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants