Skip to content

Dev/graded spike pre trace#679

Merged
PhilippPlank merged 6 commits intomainfrom
dev/graded_spike_pre_trace
May 5, 2023
Merged

Dev/graded spike pre trace#679
PhilippPlank merged 6 commits intomainfrom
dev/graded_spike_pre_trace

Conversation

@weidel-p
Copy link
Copy Markdown
Contributor

@weidel-p weidel-p commented May 2, 2023

Issue Number:
https://github.com/intel-collab/frameworks.ai.lava.lava-loihi/issues/180

Objective of pull request:
In order to port the "use graded spikes in pre-traces" feature to Loihi we need to manually fix the integer values of the GradedSpikeCfg.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@weidel-p weidel-p requested review from PhilippPlank and gkarray May 2, 2023 09:02
@PhilippPlank PhilippPlank merged commit d7a2f16 into main May 5, 2023
@PhilippPlank PhilippPlank deleted the dev/graded_spike_pre_trace branch May 5, 2023 12:13
@tim-shea tim-shea added this to the Lava v0.7.1 milestone May 15, 2023
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
* using fixed integers for GradedSpikeCfg

* fix error in clip weights

* revert weight clipping

* minor bug fix

---------

Co-authored-by: PhilippPlank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants